-
Notifications
You must be signed in to change notification settings - Fork 220
kie-issues:129: Revisit 'Open in KIE Sandbox' button #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d81a6f
to
0283980
Compare
Incorporating the feedback I got from team. Will mark as ready for review once I am done. |
For: - Project home screen (e.g. https://github.com/apache/incubator-kie-kogito-examples or https://github.com/apache/incubator-kie-kogito-examples/tree/stable) - Project file screen (e.g. https://github.com/apache/incubator-kie-kogito-examples/blob/stable/kogito-quarkus-examples/dmn-quarkus-example/src/main/resources/Traffic%20Violation.dmn) For more details see: - apache/incubator-kie-issues#129
0283980
to
96027bb
Compare
yesamer
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thank you @jomarko
tiagobento
approved these changes
Jan 9, 2024
tiagobento
pushed a commit
to tiagobento/incubator-kie-tools
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR display the 'Open in KIE Sandbox' button for:
and this PR removes the 'Open in KIE Sandbox' button for:
For more details see: