Skip to content

kie-issues:129: Revisit 'Open in KIE Sandbox' button #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Jan 4, 2024

@jomarko jomarko added pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development area:core labels Jan 4, 2024
@jomarko jomarko force-pushed the kie-issues#129-frontend branch from 6d81a6f to 0283980 Compare January 5, 2024 09:43
@jomarko jomarko removed pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Jan 5, 2024
@jomarko jomarko marked this pull request as ready for review January 5, 2024 10:10
@jomarko jomarko requested a review from yesamer January 5, 2024 12:24
@jomarko jomarko marked this pull request as draft January 8, 2024 14:51
@jomarko jomarko added pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Jan 8, 2024
@jomarko
Copy link
Contributor Author

jomarko commented Jan 8, 2024

Incorporating the feedback I got from team. Will mark as ready for review once I am done.

@jomarko jomarko force-pushed the kie-issues#129-frontend branch from 0283980 to 96027bb Compare January 9, 2024 10:37
@jomarko jomarko removed pr: DO NOT MERGE Draft PR, not ready for merging pr: wip PR is still under development labels Jan 9, 2024
@jomarko jomarko changed the title kie-issues:129: Add missing 'Open in KIE Sandbox' button kie-issues:129: Revisit 'Open in KIE Sandbox' button Jan 9, 2024
@jomarko jomarko marked this pull request as ready for review January 9, 2024 10:43
Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thank you @jomarko

@tiagobento tiagobento merged commit f81d29d into apache:main Jan 9, 2024
tiagobento pushed a commit to tiagobento/incubator-kie-tools that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants