Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kie-issues-1909: Review usage of Fabric8 and tests, remove deprecated APIs #3880

Merged
merged 3 commits into from
Apr 4, 2025

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Apr 1, 2025

Many thanks for submitting your Pull Request ❤️!

Fix apache/incubator-kie-issues#1909

Description:
Uff. That was worse than I thought at first.

In this PR:

  • Removed about-to-be-deprecated quarkus-openshift-client-test dependency
  • Review the whole QuarkusTestResource with the aforementioned dependency removal
  • Review the way we create objects and preserve status and uid inheritance

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

@apache apache deleted a comment from kie-ci3 Apr 2, 2025
@apache apache deleted a comment from kie-ci3 Apr 2, 2025
@apache apache deleted a comment from kie-ci3 Apr 3, 2025
@ricardozanini
Copy link
Member Author

@porcelli @fjtirado @wmedvede the PR is ready, please review.

@ricardozanini ricardozanini merged commit 5396c2c into apache:main Apr 4, 2025
7 checks passed
@ricardozanini ricardozanini deleted the kie-issues-1909 branch April 4, 2025 16:41
saumya1singh pushed a commit to saumya1singh/kogito-runtimes that referenced this pull request Apr 9, 2025
…ated APIs (apache#3880)

* Fix kie-issues-1909: Review usage of Fabric8 and tests, remove deprecated APIs

Signed-off-by: Ricardo Zanini <[email protected]>

* Disable kubernetes test devservices

Signed-off-by: Ricardo Zanini <[email protected]>

* Add default namespace; align fabric8 version

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kogito: Review usage of fabric8 extension
4 participants