Incubator-kie-issues-3871] Repeating timer gets executed immediately

[abhijithumbe]

#3871

Using timer node with timer expression R/PT5M, the job gets executed immediately, then in the configured 5min intervals.

[abduljaleelak]

If we need to cover this targeted logic, we can add below junit

@Test
    public void testDefaultDelay() {
        String isoString = "R/PT0M";
        long[] parsedRepeatable = DateTimeUtils.parseRepeatableDateTime(isoString);
        // Default delay time is 1000ms
        assertThat(parsedRepeatable[1]).isEqualTo(1000L);
    }

[martinweiler]

I think we should have the same test here as it was used in v7:
https://github.com/kiegroup/jbpm/blob/main/jbpm-flow/src/test/java/org/jbpm/process/core/timer/DateTimeUtilsTest.java#L126-L136

In the new syntax, this would be:

        assertThat(parsedRepeatable[0]).isEqualTo(-1L);
        assertThat(parsedRepeatable[1] <= MINUTE_IN_MILLISECONDS).as("Parsed delay is bigger than " + MINUTE_IN_MILLISECONDS).isTrue();
        assertThat(parsedRepeatable[1] > FIFTY_NINE_SECONDS_IN_MILLISECONDS)
                .as("Parsed delay is too low! Expected value is between " + MINUTE_IN_MILLISECONDS + " and " + FIFTY_NINE_SECONDS_IN_MILLISECONDS + " but is " + parsedRepeatable[1]).isTrue();
        assertThat(parsedRepeatable[2]).as("Parsed period should be one minute in milliseconds but is " + parsedRepeatable[2]).isEqualTo(MINUTE_IN_MILLISECONDS);

Not directly linked to this change, but as you are on it, I think it might be a good idea to add the additional tests from v7 (starting in L138) to the codebase as well.

[abhijithumbe]

@martinweiler Thank you for looking into this. I have included additional tests as you suggested.Please take a look.

[martinweiler]

Great job @abhijithumbe