This repository was archived by the owner on Mar 3, 2023. It is now read-only.
correct reference to values #3632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfischer1108
requested review from
nicknezis,
windhamwong,
huijunwu,
nwangtw,
Code0x58 and
nlu90
Code0x58
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this PR
helm installwould fail because helm was trying to substitute a number instead of string. The error would look something like below.There is still some work to do on the helm chart and bookkeeper. This is a start of that work. I'll follow up with details of what else needs to be done via github issues and the mailing list.