This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Clean heron-ui backend #3597
Merged
Clean heron-ui backend #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code0x58
force-pushed
the
clean-ui-backend
branch
5 times, most recently
from
c5ed819 to
a954a23
Compare
|
Tested on MacOs
|
Code0x58
force-pushed
the
clean-ui-backend
branch
2 times, most recently
from
acc615b to
1a5e07a
Compare
|
Thanks @huijunw - nice logs+reproduction examples! The logs + download file were bugs introduced in the PR, but fixed fixed in the updated branch now. The pid/jmap/mem*/stack links just seem to not work, the tracker is returning 404 (which it does for any exception), and it seems to be doing that on master as well when testing with the local cluster |
Code0x58
force-pushed
the
clean-ui-backend
branch
3 times, most recently
from
5f26afa to
eb610da
Compare
|
The reported issues that were introduced by this PR have been fixed, and merge conflicts with the explorer have just been resolved. Affected components:
|
|
Good work! I am a little concerned about: "Async querying of the tracker was dropped". Does it mean when UI is requesting data from tracker, the UI will not response? "Topology Metrics" what is missing now? |
nwangtw
reviewed
Aug 16, 2020
| @@ -7,7 +7,7 @@ pex_library( | |||
| ), | |||
| reqs = [ | |||
| "requests==2.12.3", | |||
| "tornado==4.0.2", | |||
| "tornado==4.5.3", | |||
There was a problem hiding this comment.
both heron-shell and heron-tracker use tornado still, this PR just removes the use of it in explorer+UI. I forgot to remove tornado from the reqs of the explorer after rebasing though
|
Thanks! The UI server continues to be able to serve multiple HTTP requests in parallel, it just may take longer to respond as it make requests to the tracker sequentially now. Using async requests would be a nice change again, but that may be nicer/almost free in the future after changing the tracker to use FastAPI, as the generated OpenAPI spec may be usable to auto-generate client libs. The "Topology Metrics" didn't always render to some of timelines. The logs made it look like multiplication was failing as it expected the 2nd timeseries to be univariate but |
|
Sounds good to me. I will leave it to @huijunw to approve since he is running tests. |
|
@huijunw anything else we need to check on this pr? |
Code0x58
force-pushed
the
clean-ui-backend
branch
2 times, most recently
from
c8ca580 to
a2afb1e
Compare
* replace tornado server with FastAPI+Jinja2+Uvicorn * factor out torado from heron.tools.common * add type annotations * expose port 8889 of Vagrant VM for heron-ui * pin to latest 4.x version of Tornado * visual changes to container pages This should only be an internal refactor. Async querying of the tracker was dropped, but could be reintroduced using [aiohttp](https://docs.aiohttp.org/en/stable/) if speed becomes an issue for requests that aggregate tracker data.
Code0x58
force-pushed
the
clean-ui-backend
branch
from
a2afb1e to
b25280f
Compare
Code0x58
force-pushed
the
clean-ui-backend
branch
from
b25280f to
77643ca
Compare
|
looks good to me |
huijunwu
approved these changes
Nov 11, 2020
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be an internal refactor.
Async querying of the tracker was dropped, but could be reintroduced
using aiohttp if speed becomes
an issue for requests that aggregate tracker data.
This will have a conflict with #3588 which I'll fix after the first merge. A follow on may be to add aupdate: the PR has now been rebased and the tracker client updates have been applied to explorerheron-uismoke test, maybe with something like headless chromium and grepping the logs.