Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Distribution Dockerfile missing ncat and other cleanup #3552

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Distribution Dockerfile missing ncat and other cleanup #3552

merged 3 commits into from
Jul 1, 2020

Conversation

nicknezis
Copy link
Contributor

@nicknezis nicknezis commented Jun 30, 2020 •
edited
Loading

  1. Fixes Netcat missing from some of the distribution Dockerfiles #3548
  2. Now using JRE instead of JDK for distribution images
  3. Package install cleanup to reduce resulting docker image size. Especially when not squashed.
  4. Removed python-dev packages
  5. Removed python3 packages

@nicknezis nicknezis self-assigned this Jun 30, 2020
@nicknezis
Removing software-properties-common
c5f8057 
Only needed if using `add-apt-repository`
nwangtw
nwangtw approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@nwangtw nwangtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about centos7.

docker/dist/Dockerfile.dist.centos7
&& yum -y update \
&& yum -y install \
curl \
java-11-openjdk-headless \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a jre version for centos7 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I tried looking for one and couldn't find it. There is a java-11-openjdk-devel which I think is JDK, but when I install the package in the pull request, it still includes the -devel package. So I'm not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KK. No worries. This is a huge improvement. Thanks~

@nicknezis nicknezis merged commit fb970eb into master Jul 1, 2020
@nicknezis nicknezis deleted the nicknezis/dist-image-ncat-fix branch July 1, 2020 06:45
nicknezis added a commit that referenced this pull request Sep 14, 2020
@nicknezis
Distribution Dockerfile missing ncat and other cleanup (#3552)
093a033 
* Distribution Dockerfile cleanup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nwangtw nwangtw nwangtw approved these changes

@joshfischer1108 joshfischer1108 joshfischer1108 approved these changes

Assignees

@nicknezis nicknezis

Labels
Docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netcat missing from some of the distribution Dockerfiles
3 participants
@nicknezis @joshfischer1108 @nwangtw