Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Fix Heron Shell PID Extractor #3528

Merged
merged 2 commits into from
May 19, 2020
Merged

Fix Heron Shell PID Extractor #3528

merged 2 commits into from
May 19, 2020

Conversation

xiaoyao1991
Copy link
Member

@xiaoyao1991 xiaoyao1991 commented May 18, 2020 •
edited
Loading

I'm getting the following error when trying to get the PID from Heron shell

<subprocess.Popen object at 0x7fdf75323e90>
>>> awk: cmd. line:1: '{print $2}'
awk: cmd. line:1: ^ invalid char ''' in expression
grep: write error: Broken pipe

But then I saw #3094 ... so I guess different OS have different tolerance over quotations. I'm changing the PID extraction logic to read the PID file instead to avoid this.

@xiaoyao1991 xiaoyao1991 merged commit d05f6e9 into apache:master May 19, 2020
nicknezis pushed a commit that referenced this pull request Sep 14, 2020
@xiaoyao1991
Fix Heron Shell PID Extractor (#3528)
4a6b8a0 
* Fix Heron Shell PID Extractor

* read pid file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huijunwu huijunwu huijunwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoyao1991 @huijunwu