This repository was archived by the owner on Mar 3, 2023. It is now read-only.
add downloader-core filegroup #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huijunwu
approved these changes
Jan 22, 2020
nwangtw
reviewed
Jan 29, 2020
| @@ -47,13 +47,6 @@ | |||
| "restartArgs" : "True", | |||
| "expectedTopoResultRelativePath" : "fields_grouping/FieldsGroupingResults.json", | |||
| "checkType" : "topology_structure" | |||
| }, | |||
There was a problem hiding this comment.
This change might affect integration test?
There was a problem hiding this comment.
This integration test fails occasionally and cannot be reproduced locally.
Temporary removing it will unblock other work.
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
* add downloader-core filegroup * remove failing test
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* add downloader-core filegroup * remove failing test
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Nov 25, 2020
* add downloader-core filegroup * remove failing test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this new filegroup allows other people building downloaders jar without including unexpected dependencies, such as distributed-log etc.