This repository was archived by the owner on Mar 3, 2023. It is now read-only.
BUG: bookie statefulset helm template specifies incorrect service name #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it might also be worth noting the yaml in general is doing this correctly, and also utilizing the following annotation: incubator-heron/deploy/kubernetes/general/bookkeeper.statefulset.yaml Lines 126 to 127 in d8db1c5 which is the same annotation being utilized by pulsar's bookie: https://github.com/apache/pulsar/blob/master/deployment/kubernetes/helm/pulsar/values.yaml#L97 |
|
added an additional commit to add that annotation |
nwangtw
approved these changes
Nov 28, 2019
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
apache#3410) * Update bookie template to use correct service name * helm add bookie toleration for unready endpoints
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
#3410) * Update bookie template to use correct service name * helm add bookie toleration for unready endpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statefulset's service name:
https://github.com/apache/incubator-heron/blob/master/deploy/kubernetes/helm/templates/bookie.yaml#L74
Doesnt match the actual name of the service:
https://github.com/apache/incubator-heron/blob/master/deploy/kubernetes/helm/templates/bookie.yaml#L203
I believe bookie previously was using the podIPs to connect and the service wasnt actually getting used. Changing the useBookieHostNameAsID to true caused the helm chart to use the service for the first time to connect, which ultimately failed since it was named the wrong name.