This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Re-organize UI elements in Heorn UI topology page #3397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwangtw
requested review from
xiaoyao1991,
huijunwu,
nlu90 and
joshfischer1108
|
|
huijunwu
approved these changes
Nov 8, 2019
You mean making the plan diagrams sticky? Yeah, I think that could be helpful. Let me think about it. Will be in a new PR. Thanks for the feedback. |
thinker0
added a commit
to thinker0/heron
that referenced
this pull request
Nov 10, 2019
* master: Re-organize UI elements in Heorn UI topology page (apache#3397) Update the instruction for using the docker based development environment (apache#3395) Add tables for component running info (apache#3394) Helm chart Bookkeeper fix (apache#3381) Docker site (apache#3393) Refactor counters sections in Heron UI topology page (apache#3392) fix base url and counters flag; combine metrics requests (apache#3385) makemetricstriggerperiodic (apache#3384) Fix max capacity timeline in Heron UI (apache#3383) Avoid duplicated metrics requests in Heron UI (apache#3378) Add instance resource usage in container (apache#3375) Clean up license for healthHandler and jarjar help.txt (apache#3377) Fix license in health handler py (apache#3376) updating the NOTICE (apache#3374)
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the topology page, create a navigator to show stats, counters and config.
The motivation is that counters have a lot of important information, but they are shown below the page and not very noticeable for users. They are also far from the plan diagrams so that it is hard to choose different component/instance to view the counters. Creating a "counters" tab make the counters easier to read.
Config was in a separated page which is not convenient. Now it is integrated in the same page under the "config" tab.