Skip to content

Fixes up PDF summarizer example #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Fixes up PDF summarizer example #258

merged 1 commit into from
Aug 6, 2023

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Aug 6, 2023

The request wasn't wired correctly through on the server. When posting files, you have to use the Form object in fastapi if you're also passing in other information.

Also changes DAG to make it clearer to track what the final content passed to the LLM would be.

Changes

  • pdf summarizer example

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

The request wasn't wired correctly through on the server.
When posting files, you have to use the Form object in fastapi if
you're also passing in other information.

Also changes DAG to make it clearer to track what the final
content passed to the LLM would be.
@skrawcz skrawcz merged commit 734f5b6 into main Aug 6, 2023
@skrawcz skrawcz deleted the update_pdf_summarizer branch August 6, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant