-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17767. Skip tests that depend on custom SecurityManager when Java doesn't support it #7566
base: trunk
Are you sure you want to change the base?
Conversation
…a doesn't support it
🎊 +1 overall
This message was automatically generated. |
@ayushtkn @Hexiaoqiao Could you please review this pr? Thank you very much! |
@@ -576,26 +577,33 @@ public void run() { | |||
//use SecurityManager to pause the copying of f1 and begin copying f2 | |||
SecurityManager sm = System.getSecurityManager(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to involve me here. As #7567 mentioned, "System.getSecurityManager() will also be one Deprecate APIs based on JEP-411, Would you mind to process it together." Thanks. Others make sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I've moved getSecurityManager inside the try block.
🎊 +1 overall
This message was automatically generated. |
Description of PR
Skip tests that depend on custom SecurityManager when Java doesn't support it
Required for recent Java versions.
How was this patch tested?
Run on Java 24 on my Java 24 branch.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?