Draft: feat(java): row encoder array deserialization into List supports lazy access #2358
+290
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenschlansker
force-pushed
the
lazy-array
branch
from
bb9819d to
d9cb597
Compare
… access this way if you use only some indexes, you don't pay deserialization costs for any unread indexes
stevenschlansker
changed the title
stevenschlansker
force-pushed
the
lazy-array
branch
from
d9cb597 to
8548257
Compare
|
Still a couple test cases to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way if you use only some indexes, you don't pay deserialization costs for any unread indexes
Does this PR introduce any user-facing change?
When List subtype is not specified, now we use our own lazy list. Since the user did not specify type, it should be ok, and you can always specify
ArrayListto materialize the list eagerly