Skip to content

feat(python): bump cython to 3.1.1 #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

Conversation

penguin-wwy
Copy link
Contributor

What does this PR do?

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

fory_large_tuple: Mean +- std dev: [base] 116 ms +- 5 ms -> [new] 115 ms +- 1 ms: 1.01x faster
fory_large_float_tuple: Mean +- std dev: [base] 142 ms +- 3 ms -> [new] 137 ms +- 9 ms: 1.04x faster
fory_large_boolean_tuple: Mean +- std dev: [base] 43.6 ms +- 0.6 ms -> [new] 37.8 ms +- 0.4 ms: 1.15x faster
fory_large_list: Mean +- std dev: [base] 119 ms +- 4 ms -> [new] 117 ms +- 1 ms: 1.02x faster

Benchmark hidden because not significant (5): fory_dict, fory_large_dict, fory_dict_group, fory_tuple, fory_list

Geometric mean: 1.02x faster

@penguin-wwy penguin-wwy requested a review from chaokunyang as a code owner June 9, 2025 14:35
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit fbd4388 into apache:main Jun 9, 2025
50 checks passed
@penguin-wwy penguin-wwy deleted the py_dev branch June 9, 2025 14:56
chaokunyang pushed a commit to chaokunyang/fury that referenced this pull request Jun 9, 2025
<!--
**Thanks for contributing to Fory.**

**If this is your first time opening a PR on fory, you can refer to
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).**

Contribution Checklist

- The **Apache Fory (incubating)** community has restrictions on the
naming of pr titles. You can also find instructions in
[CONTRIBUTING.md](https://github.com/apache/fory/blob/main/CONTRIBUTING.md).

- Fory has a strong focus on performance. If the PR you submit will have
an impact on performance, please benchmark it first and provide the
benchmark result here.
-->

## What does this PR do?

<!-- Describe the purpose of this PR. -->

## Related issues

<!--
Is there any related issue? Please attach here.

- #xxxx0
- #xxxx1
- #xxxx2
-->

## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/fory/issues/new/choose) describing the
need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?

## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
fory_large_tuple: Mean +- std dev: [base] 116 ms +- 5 ms -> [new] 115 ms
+- 1 ms: 1.01x faster
fory_large_float_tuple: Mean +- std dev: [base] 142 ms +- 3 ms -> [new]
137 ms +- 9 ms: 1.04x faster
fory_large_boolean_tuple: Mean +- std dev: [base] 43.6 ms +- 0.6 ms ->
[new] 37.8 ms +- 0.4 ms: 1.15x faster
fory_large_list: Mean +- std dev: [base] 119 ms +- 4 ms -> [new] 117 ms
+- 1 ms: 1.02x faster

Benchmark hidden because not significant (5): fory_dict,
fory_large_dict, fory_dict_group, fory_tuple, fory_list

Geometric mean: 1.02x faster

Co-authored-by: wenyangwang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants