feat(java): support multi-dimensional array field serialization in xlang meta shared mode #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaokunyang
reviewed
Jun 9, 2025
| @@ -466,6 +466,10 @@ private ClassInfo buildClassInfo(Class<?> cls) { | |||
| return info; | |||
| } | |||
|
|
|||
| private boolean handleArray(Class<?> cls) { | |||
| return !TypeUtils.getArrayComponent(cls).isPrimitive() || !cls.getComponentType().isPrimitive(); | |||
There was a problem hiding this comment.
Seems this can be simplified into:
Suggested change
| return !TypeUtils.getArrayComponent(cls).isPrimitive() || !cls.getComponentType().isPrimitive(); | |
| return !cls.getComponentType().isPrimitive(); |
There was a problem hiding this comment.
And I prefer inline it into the caller, instead of creating a new method
chaokunyang
added a commit
to chaokunyang/fury
that referenced
this pull request
Jun 9, 2025
…ang meta shared mode (apache#2314) ## What does this PR do? support multi-dimensional array field serialization in xlang meta shared mode ## Related issues apache#2277 ## Does this PR introduce any user-facing change? - [ ] Does this PR introduce any public API change? - [ ] Does this PR introduce any binary protocol compatibility change? ## Benchmark --------- Co-authored-by: Shawn Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
support multi-dimensional array field serialization in xlang meta shared mode
Related issues
#2277
Does this PR introduce any user-facing change?
Benchmark