Skip to content

feat(javascript): add data to description util #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2024
Merged

feat(javascript): add data to description util #1609

merged 4 commits into from
May 8, 2024

Conversation

bytemain
Copy link
Contributor

@bytemain bytemain commented May 7, 2024

What does this PR do?

Add a new util called data2Description, which can reduce the amount of code

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@bytemain bytemain requested a review from theweipeng as a code owner May 7, 2024 07:26
@bytemain bytemain changed the title feat(javascript): add a data to description util WIP: feat(javascript): add a data to description util May 7, 2024
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain changed the title WIP: feat(javascript): add a data to description util WIP: feat(javascript): add data to description util May 7, 2024
@bytemain bytemain changed the title WIP: feat(javascript): add data to description util feat(javascript): add data to description util May 7, 2024
@drewbitt
Copy link

drewbitt commented May 7, 2024

This was needed. Thanks.

@chaokunyang chaokunyang merged commit 8b3fe0e into apache:main May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants