Skip to content

fix diff method can not be added to RadixTree #15445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

Stellar1999
Copy link
Contributor

What is the purpose of the change?

try fix issue #15433

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 60.96%. Comparing base (c31164a) to head (1106ae6).

Files with missing lines Patch % Lines
...bo/rpc/protocol/tri/rest/mapping/Registration.java 21.42% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15445      +/-   ##
============================================
+ Coverage     60.90%   60.96%   +0.06%     
+ Complexity    11455    11447       -8     
============================================
  Files          1888     1888              
  Lines         86309    86327      +18     
  Branches      12933    12945      +12     
============================================
+ Hits          52570    52633      +63     
+ Misses        28302    28267      -35     
+ Partials       5437     5427      -10     
Flag Coverage Δ
integration-tests-java17 33.10% <23.80%> (-0.01%) ⬇️
integration-tests-java8 33.14% <23.80%> (-0.04%) ⬇️
samples-tests-java17 31.43% <0.00%> (-0.04%) ⬇️
samples-tests-java8 29.28% <0.00%> (+<0.01%) ⬆️
unit-tests 58.89% <47.61%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw
Copy link
Contributor

zrlw commented Jun 9, 2025

add unit tests from #15433 ?

@Stellar1999
Copy link
Contributor Author

add unit tests from #15433 ?

Sure,I'll do it later.

@Stellar1999
Copy link
Contributor Author

@oxsean PTAL

Copy link
Contributor

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comments.

@Stellar1999
Copy link
Contributor Author

Please fix the comments.

done.

Copy link
Contributor

@oxsean oxsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Stellar1999 Stellar1999 force-pushed the fix/RadixTree branch 3 times, most recently from 8eac0de to 4d91b37 Compare June 10, 2025 15:04
@Stellar1999
Copy link
Contributor Author

@oxsean Please take a look again.I changed Overlap method.

@Stellar1999 Stellar1999 force-pushed the fix/RadixTree branch 2 times, most recently from 722d7bc to 36570d5 Compare June 11, 2025 07:03
@oxsean oxsean merged commit e849678 into apache:3.3 Jun 11, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants