Skip to content

[Feature] Add spring 6.1.5,spring-boot 3.2.3,jdk17 to the candidate versions of dubbo workflows #15417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

zrlw
Copy link
Contributor

@zrlw zrlw commented May 30, 2025

What is the purpose of the change?

  1. Add spring 6.1.5 and spring-boot 3.2.3 to the candidate versions of PR,3.3,release-test workflows.
  2. Add jdk17 jobs to PR workflow.
  3. Fix wrong profile ids in workflows.

There are many integration and samples test projects could only run on spring 6.* and jdk17+. We can promptly identify any issues with the testing program or dubbo if the candidate versions include spring6 and jdk17.
e.g. No provider available issue of dubbo-samples/dubbo-servicediscovery-migration:
see details at https://github.com/apache/dubbo-samples/actions/runs/15306242647/job/43059693107
image

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.85%. Comparing base (2af3a91) to head (4c8e4a7).
Report is 1 commits behind head on 3.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15417      +/-   ##
============================================
- Coverage     60.74%   58.85%   -1.89%     
+ Complexity    10934       12   -10922     
============================================
  Files          1887     1887              
  Lines         86242    86263      +21     
  Branches      12927    12929       +2     
============================================
- Hits          52391    50774    -1617     
- Misses        28377    29944    +1567     
- Partials       5474     5545      +71     
Flag Coverage Δ
integration-tests ?
samples-tests ?
unit-tests 58.85% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zrlw zrlw force-pushed the 3.3-feature-addSpring6Candidates branch 2 times, most recently from 7526877 to 33b0197 Compare May 31, 2025 01:55
@zrlw zrlw force-pushed the 3.3-feature-addSpring6Candidates branch from 33b0197 to 7d56cb2 Compare May 31, 2025 02:12
@zrlw zrlw changed the title [Feature] Add spring 6.1.5 and spring-boot 3.2.3 to workflow candidate versions [Feature] Add spring 6.1.5 and spring-boot 3.2.3 to the candidate versions of dubbo workflows Jun 1, 2025
@zrlw zrlw force-pushed the 3.3-feature-addSpring6Candidates branch from d9de4c3 to 59340fc Compare June 2, 2025 03:25
@zrlw zrlw force-pushed the 3.3-feature-addSpring6Candidates branch from 59340fc to 59dbc94 Compare June 2, 2025 03:28
@zrlw zrlw changed the title [Feature] Add spring 6.1.5 and spring-boot 3.2.3 to the candidate versions of dubbo workflows [Feature] Add spring 6.1.5,spring-boot 3.2.3,jdk17 to the candidate versions of dubbo workflows Jun 2, 2025
@zrlw zrlw force-pushed the 3.3-feature-addSpring6Candidates branch from dbdc8d4 to 4c8e4a7 Compare June 5, 2025 03:03
@zrlw
Copy link
Contributor Author

zrlw commented Jun 5, 2025

@AlbumenJ PTAL

@zrlw zrlw merged commit 6f110c1 into apache:3.3 Jun 5, 2025
25 of 27 checks passed
@zrlw zrlw deleted the 3.3-feature-addSpring6Candidates branch June 6, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants