Optimize: remove deplicate judge available #2908
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1kasa
reviewed
Jun 3, 2025
| } | ||
|
|
||
| if !di.BaseInvoker.IsAvailable() { | ||
| // Generally, the case will not happen, because the invoker has been removed |
There was a problem hiding this comment.
Can you explain why you want to delete it? If you delete it, will there be a certain risk of causing race conditions in high concurrency scenarios? I hope to get an answer
There was a problem hiding this comment.
You need to take a look at the complete Invoke method of dubbo Invoker. This function checks available twice, and the Invoke function is called very frequently, so it shouldn't spend extra time checking twice. The triple invoker only checks once, and the dubbo invoker should be synchronized with the triple invoker.
marsevilspirit
force-pushed
the
remove-deplicate-judge-available
branch
from
e72d0ea to
31d31fa
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for determining whether the invoker is available is repeated.