Replace copier.Copy with optimized manual deep copy in URL.Clone (#2678) #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@No-SilverBullet @AlexStocks plz review this , i have changed it acc to your suggestions in this new pr and also fixed the cl error. |
AlexStocks
approved these changes
Mar 26, 2025
FoghostCn
reviewed
Mar 26, 2025
common/url.go
Outdated
| @@ -779,6 +779,14 @@ func (c *URL) MergeURL(anotherUrl *URL) *URL { | |||
| // After Clone, it is a new URL that there is no thread safe issue. | |||
| mergedURL := c.Clone() | |||
| params := mergedURL.GetParams() | |||
| if params == nil { | |||
| mergedURL.paramsLock.Lock() | |||
There was a problem hiding this comment.
no need to lock because mergedURL is a local variable
There was a problem hiding this comment.
Yes i have done the changes but getting this drafter error
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is related to pr (#2799 )