Skip to content

Fix some potential resource leak #18106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025
Merged

Fix some potential resource leak #18106

merged 7 commits into from
Jun 10, 2025

Conversation

xcx1r3
Copy link
Contributor

@xcx1r3 xcx1r3 commented Jun 10, 2025

Fixes #18086.

Description

I've used try-with stmt to close the resource mentioned in #18086, and found some other leaks in this project and fix them with try-with too.

Release note

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz merged commit 58a8d76 into apache:master Jun 10, 2025
136 of 138 checks passed
@kfaraz
Copy link
Contributor

kfaraz commented Jun 10, 2025

Thanks for contributing to Apache Druid, @xcx1r3 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ResultSet may lead to resource leak in DerbyConnector
2 participants