apache · Gabriel39 · Jun 9, 2025 · Jun 9, 2025
diff --git a/be/src/runtime/define_primitive_type.h b/be/src/runtime/define_primitive_type.h
@@ -50,24 +50,25 @@ enum PrimitiveType : PrimitiveNative {
 
     TYPE_TIME [[deprecated]], /*TYPE_TIMEV2*/
 
-    TYPE_BITMAP,          /* 22, bitmap */
-    TYPE_STRING,          /* 23 */
-    TYPE_QUANTILE_STATE,  /* 24 */
-    TYPE_DATEV2,          /* 25 */
-    TYPE_DATETIMEV2,      /* 26 */
-    TYPE_TIMEV2,          /* 27 */
-    TYPE_DECIMAL32,       /* 28 */
-    TYPE_DECIMAL64,       /* 29 */
-    TYPE_DECIMAL128I,     /* 30, v3 128bit */
-    TYPE_JSONB,           /* 31 */
-    TYPE_VARIANT,         /* 32 */
-    TYPE_LAMBDA_FUNCTION, /* 33 */
-    TYPE_AGG_STATE,       /* 34 */
-    TYPE_DECIMAL256,      /* 35 */
-    TYPE_IPV4,            /* 36 */
-    TYPE_IPV6,            /* 37 */
-    TYPE_UINT32,          /* 38, used as offset */
-    TYPE_UINT64           /* 39, used as offset */
+    TYPE_BITMAP,             /* 22, bitmap */
+    TYPE_STRING,             /* 23 */
+    TYPE_QUANTILE_STATE,     /* 24 */
+    TYPE_DATEV2,             /* 25 */
+    TYPE_DATETIMEV2,         /* 26 */
+    TYPE_TIMEV2,             /* 27 */
+    TYPE_DECIMAL32,          /* 28 */
+    TYPE_DECIMAL64,          /* 29 */
+    TYPE_DECIMAL128I,        /* 30, v3 128bit */
+    TYPE_JSONB,              /* 31 */
+    TYPE_VARIANT,            /* 32 */
+    TYPE_LAMBDA_FUNCTION,    /* 33 */
+    TYPE_AGG_STATE,          /* 34 */
+    TYPE_DECIMAL256,         /* 35 */
+    TYPE_IPV4,               /* 36 */
+    TYPE_IPV6,               /* 37 */
+    TYPE_UINT32,             /* 38, used as offset */
+    TYPE_UINT64,             /* 39, used as offset */
+    TYPE_FIXED_LENGTH_OBJECT /* 40, represent fixed-length object on BE */
 };
 
 } // namespace doris
diff --git a/be/src/vec/data_types/data_type.cpp b/be/src/vec/data_types/data_type.cpp
@@ -169,13 +169,8 @@ PGenericType_TypeId IDataType::get_pdata_type(const IDataType* data_type) {
         return PGenericType::AGG_STATE;
     case PrimitiveType::TYPE_TIMEV2:
         return PGenericType::TIMEV2;
-    case PrimitiveType::INVALID_TYPE: {
-        // TODO(gabriel): we need another primitive type to represent FixedLengthObject
-        if (data_type->is_fixed_length_object()) {
-            return PGenericType::FIXEDLENGTHOBJECT;
-        }
-        break;
-    }
+    case PrimitiveType::TYPE_FIXED_LENGTH_OBJECT:
+        return PGenericType::FIXEDLENGTHOBJECT;
     default:
         break;
     }

diff --git a/be/src/vec/data_types/data_type.h b/be/src/vec/data_types/data_type.h
@@ -97,8 +97,6 @@ class IDataType : private boost::noncopyable {
 
     // get specific serializer or deserializer
     virtual DataTypeSerDeSPtr get_serde(int nesting_level = 1) const = 0;
-    // FIXME(gabriel):Fixed length object type will be used in some cases but it is not supported by primitive type
-    virtual bool is_fixed_length_object() const { return false; }
 
 protected:
     virtual String do_get_name() const;

diff --git a/be/src/vec/data_types/data_type_fixed_length_object.h b/be/src/vec/data_types/data_type_fixed_length_object.h
@@ -38,15 +38,15 @@ class IColumn;
 class DataTypeFixedLengthObject final : public IDataType {
 public:
     using ColumnType = ColumnFixedLengthObject;
-    static constexpr PrimitiveType PType = INVALID_TYPE;
+    static constexpr PrimitiveType PType = TYPE_FIXED_LENGTH_OBJECT;
 
     DataTypeFixedLengthObject() = default;
 
     DataTypeFixedLengthObject(const DataTypeFixedLengthObject& other) {}
 
     const std::string get_family_name() const override { return "DataTypeFixedLengthObject"; }
 
-    PrimitiveType get_primitive_type() const override { return PrimitiveType::INVALID_TYPE; }
+    PrimitiveType get_primitive_type() const override { return PType; }
 
     doris::FieldType get_storage_field_type() const override {
         return doris::FieldType::OLAP_FIELD_TYPE_NONE;
@@ -57,7 +57,6 @@ class DataTypeFixedLengthObject final : public IDataType {
     [[noreturn]] Field get_field(const TExprNode& node) const override {
         throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
                                "Unimplemented get_field for DataTypeFixedLengthObject");
-        __builtin_unreachable();
     }
 
     bool equals(const IDataType& rhs) const override { return typeid(rhs) == typeid(*this); }
@@ -76,7 +75,6 @@ class DataTypeFixedLengthObject final : public IDataType {
     DataTypeSerDeSPtr get_serde(int nesting_level = 1) const override {
         return std::make_shared<DataTypeFixedLengthObjectSerDe>(nesting_level);
     };
-    bool is_fixed_length_object() const override { return true; }
 };
 
 } // namespace doris::vectorized
diff --git a/be/src/vec/data_types/data_type_nullable.h b/be/src/vec/data_types/data_type_nullable.h
@@ -106,9 +106,6 @@ class DataTypeNullable final : public IDataType {
         return 1 + nested_data_type->get_size_of_value_in_memory();
     }
     bool is_nullable() const override { return true; }
-    bool is_fixed_length_object() const override {
-        return nested_data_type->is_fixed_length_object();
-    }
     bool can_be_inside_low_cardinality() const override {
         return nested_data_type->can_be_inside_low_cardinality();
     }

diff --git a/be/test/vec/data_types/common_data_type_test.h b/be/test/vec/data_types/common_data_type_test.h
@@ -139,8 +139,7 @@ class CommonDataTypeTest : public ::testing::Test {
                   meta_info.is_value_unambiguously_represented_in_contiguous_memory_region);
         if (is_decimal(data_type->get_primitive_type()) || data_type->is_nullable() ||
             data_type->get_primitive_type() == TYPE_STRUCT ||
-            (data_type->get_primitive_type() == INVALID_TYPE &&
-             !data_type->is_fixed_length_object()) ||
+            data_type->get_primitive_type() == INVALID_TYPE ||
             is_number(data_type->get_primitive_type()) ||
             is_int_or_bool(data_type->get_primitive_type()) ||
             is_float_or_double(data_type->get_primitive_type()) ||

diff --git a/be/test/vec/data_types/data_type_agg_state_test.cpp b/be/test/vec/data_types/data_type_agg_state_test.cpp
@@ -140,9 +140,10 @@ void insert_data_agg_state(MutableColumns* agg_state_cols, DataTypePtr datatype_
     } else {
         assert_cast<ColumnFixedLengthObject*>((*agg_state_cols)[0].get())->set_item_size(8);
         column_fixed->resize(rows_value);
-        ASSERT_TRUE(assert_cast<const DataTypeAggState*>(datatype_agg_state.get())
-                            ->get_serialized_type()
-                            ->is_fixed_length_object());
+        ASSERT_EQ(assert_cast<const DataTypeAggState*>(datatype_agg_state.get())
+                          ->get_serialized_type()
+                          ->get_primitive_type(),
+                  TYPE_FIXED_LENGTH_OBJECT);
         auto& data = assert_cast<ColumnFixedLengthObject*>((*agg_state_cols)[0].get())->get_data();
         for (size_t i = 0; i != rows_value; ++i) {
             data[i] = i;

diff --git a/gensrc/thrift/Types.thrift b/gensrc/thrift/Types.thrift
@@ -99,7 +99,8 @@ enum TPrimitiveType {
   IPV4,
   IPV6,
   UINT32, // only used in BE to represent offsets
-  UINT64  // only used in BE to represent offsets
+  UINT64,  // only used in BE to represent offsets
+  FIXED_LENGTH_OBJECT // only used in BE to represent fixed-length object
 }
 
 enum TTypeNodeType {