-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[enhance](cloud)add log for compaction read time #51355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 33985 ms
|
TPC-DS: Total hot run time: 186417 ms
|
ClickBench: Total hot run time: 28.97 s
|
run buildall |
TPC-H: Total hot run time: 33705 ms
|
TPC-DS: Total hot run time: 193531 ms
|
ClickBench: Total hot run time: 29.39 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
run p0 |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
run buildall |
TPC-H: Total hot run time: 34094 ms
|
TPC-DS: Total hot run time: 192625 ms
|
ClickBench: Total hot run time: 29.29 s
|
9442199
to
ae97809
Compare
run buildall |
TPC-H: Total hot run time: 34498 ms
|
TPC-DS: Total hot run time: 192949 ms
|
ClickBench: Total hot run time: 29.4 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by anyone and no changes requested. |
run buildall |
TPC-H: Total hot run time: 34738 ms
|
TPC-DS: Total hot run time: 186054 ms
|
ClickBench: Total hot run time: 28.74 s
|
run external |
run buildall |
TPC-H: Total hot run time: 34342 ms
|
TPC-DS: Total hot run time: 193286 ms
|
ClickBench: Total hot run time: 29.13 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
@@ -147,6 +148,12 @@ Status Merger::vmerge_rowsets(BaseTabletSPtr tablet, ReaderType reader_type, | |||
stats_output->bytes_read_from_remote = | |||
reader.stats().file_cache_stats.bytes_read_from_remote; | |||
stats_output->cached_bytes_total = reader.stats().file_cache_stats.bytes_write_into_cache; | |||
if (config::is_cloud_mode()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if there is no cloud mode judgment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing will happen, but I think these calculations are not necessary.
run buildall |
TPC-H: Total hot run time: 33864 ms
|
TPC-DS: Total hot run time: 191995 ms
|
ClickBench: Total hot run time: 28.7 s
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
run p0 |
Problem Summary:
curl http://ip:8040/api/compaction/show?tablet_id=1748942349697