-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[feat](iceberg) Intro IcebergMetadataJniScanner to scan iceberg system table in be #51190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
suxiaogang223
wants to merge
49
commits into
apache:master
Choose a base branch
from
suxiaogang223:support_iceberg_sys_table
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[feat](iceberg) Intro IcebergMetadataJniScanner to scan iceberg system table in be #51190
suxiaogang223
wants to merge
49
commits into
apache:master
from
suxiaogang223:support_iceberg_sys_table
+1,946
−317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
reviewed
May 24, 2025
@@ -530,6 +530,9 @@ struct TIcebergMetadataParams { | |||
2: optional string catalog | |||
3: optional string database | |||
4: optional string table | |||
5: optional string serialized_table | |||
6: optional string serialized_split | |||
7: optional map<string, string> hadoop_props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think twice, what if we need to connect to s3?
2d377ba
to
25110ce
Compare
37ba16d
to
2bca0cf
Compare
a6d9f69
to
5dc6a03
Compare
81d9772
to
e6d104a
Compare
2139937
to
2f726d0
Compare
00546ea
to
ebc5b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)