Skip to content

[refactor](type) Add FIXED_LENGTH_OBJECT type #51577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gabriel39
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.32% (1119/1343)
Line Coverage 66.79% (19189/28732)
Region Coverage 66.40% (9497/14302)
Branch Coverage 56.39% (5152/9136)

@doris-robot
Copy link

TPC-H: Total hot run time: 33803 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 952854c510cb7871d00ded342b85b4c2e7d59c12, data reload: false

------ Round 1 ----------------------------------
q1	26270	5043	4979	4979
q2	1955	282	180	180
q3	10430	1265	693	693
q4	10233	1009	525	525
q5	7628	2420	2277	2277
q6	186	166	132	132
q7	930	734	618	618
q8	9291	1246	1116	1116
q9	6760	5106	5084	5084
q10	6807	2302	1887	1887
q11	501	284	282	282
q12	344	349	227	227
q13	17767	3702	3076	3076
q14	228	222	212	212
q15	560	502	500	500
q16	423	432	378	378
q17	618	865	384	384
q18	7851	7259	7170	7170
q19	1424	962	551	551
q20	337	350	228	228
q21	3655	3220	2332	2332
q22	1045	1028	972	972
Total cold run time: 115243 ms
Total hot run time: 33803 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5068	5063	5053	5053
q2	234	326	222	222
q3	2137	2677	2286	2286
q4	1378	1803	1342	1342
q5	4456	4367	4392	4367
q6	217	180	124	124
q7	2026	1920	1765	1765
q8	2567	2481	2495	2481
q9	7241	7182	6973	6973
q10	2987	3211	2738	2738
q11	578	509	502	502
q12	667	761	613	613
q13	3528	3921	3224	3224
q14	286	304	266	266
q15	547	471	492	471
q16	444	491	458	458
q17	1182	1502	1359	1359
q18	7801	7484	7624	7484
q19	790	837	953	837
q20	1992	2106	1939	1939
q21	4893	4594	4347	4347
q22	1078	1059	1033	1033
Total cold run time: 52097 ms
Total hot run time: 49884 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192578 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 952854c510cb7871d00ded342b85b4c2e7d59c12, data reload: false

query1	1396	1089	1064	1064
query2	6369	1869	1864	1864
query3	11046	4439	4421	4421
query4	53895	25766	23437	23437
query5	4919	511	463	463
query6	325	196	189	189
query7	4872	510	295	295
query8	271	238	223	223
query9	5590	2620	2628	2620
query10	442	346	285	285
query11	15052	15003	14818	14818
query12	156	110	110	110
query13	1041	525	428	428
query14	10265	6197	6343	6197
query15	208	218	182	182
query16	7144	654	463	463
query17	1087	769	629	629
query18	1571	424	337	337
query19	212	212	183	183
query20	135	134	119	119
query21	208	125	108	108
query22	4616	4404	4431	4404
query23	34320	33543	33577	33543
query24	6775	2396	2445	2396
query25	480	476	404	404
query26	713	268	155	155
query27	2333	507	350	350
query28	3029	2178	2160	2160
query29	629	574	474	474
query30	269	217	188	188
query31	852	845	782	782
query32	82	62	59	59
query33	450	352	295	295
query34	796	866	538	538
query35	828	852	735	735
query36	948	1013	900	900
query37	115	107	86	86
query38	4217	4259	4228	4228
query39	1521	1443	1427	1427
query40	212	118	104	104
query41	66	62	55	55
query42	125	109	124	109
query43	524	513	490	490
query44	1365	863	869	863
query45	190	181	165	165
query46	844	1031	670	670
query47	1875	1876	1813	1813
query48	401	414	339	339
query49	625	501	406	406
query50	650	716	413	413
query51	4194	4281	4171	4171
query52	116	114	99	99
query53	223	268	192	192
query54	577	604	523	523
query55	93	88	86	86
query56	309	300	294	294
query57	1249	1281	1149	1149
query58	268	283	278	278
query59	2771	2878	2754	2754
query60	336	320	337	320
query61	137	131	127	127
query62	759	717	688	688
query63	232	188	189	188
query64	1782	1050	741	741
query65	4203	4157	4130	4130
query66	715	391	314	314
query67	15826	15581	15416	15416
query68	7043	885	536	536
query69	557	305	264	264
query70	1194	1159	1093	1093
query71	497	319	299	299
query72	5506	4537	4831	4537
query73	1467	654	355	355
query74	8982	9063	8896	8896
query75	3817	3215	2674	2674
query76	4247	1207	763	763
query77	623	365	285	285
query78	10085	10155	9293	9293
query79	2510	830	569	569
query80	624	514	445	445
query81	494	257	222	222
query82	438	130	94	94
query83	361	246	227	227
query84	296	111	80	80
query85	838	351	304	304
query86	391	309	312	309
query87	4408	4363	4306	4306
query88	3775	2266	2282	2266
query89	405	316	286	286
query90	1819	206	207	206
query91	145	152	113	113
query92	77	58	53	53
query93	1934	929	586	586
query94	660	389	318	318
query95	373	295	357	295
query96	488	569	276	276
query97	2748	2747	2675	2675
query98	228	208	200	200
query99	1416	1388	1297	1297
Total cold run time: 298290 ms
Total hot run time: 192578 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.72 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 952854c510cb7871d00ded342b85b4c2e7d59c12, data reload: false

query1	0.03	0.04	0.03
query2	0.14	0.11	0.11
query3	0.35	0.19	0.19
query4	1.60	0.20	0.19
query5	0.47	0.46	0.45
query6	1.17	0.65	0.66
query7	0.02	0.01	0.01
query8	0.06	0.06	0.05
query9	0.61	0.51	0.53
query10	0.59	0.60	0.58
query11	0.28	0.13	0.13
query12	0.25	0.13	0.13
query13	0.63	0.62	0.62
query14	0.80	0.84	0.81
query15	0.97	0.88	0.88
query16	0.37	0.38	0.36
query17	1.00	1.07	1.09
query18	0.17	0.18	0.18
query19	2.00	1.81	1.82
query20	0.02	0.02	0.01
query21	15.40	0.99	0.68
query22	0.93	1.05	0.79
query23	14.71	1.54	0.73
query24	5.54	0.53	0.27
query25	0.17	0.09	0.08
query26	0.56	0.22	0.19
query27	0.09	0.09	0.09
query28	11.01	1.18	0.59
query29	12.54	4.16	3.41
query30	0.29	0.08	0.07
query31	2.83	0.65	0.44
query32	3.23	0.60	0.52
query33	3.21	3.04	3.13
query34	16.66	5.07	4.42
query35	4.41	4.46	4.46
query36	0.64	0.49	0.49
query37	0.19	0.17	0.17
query38	0.16	0.16	0.16
query39	0.05	0.05	0.05
query40	0.21	0.16	0.16
query41	0.11	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 104.58 s
Total hot run time: 29.72 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants