Ignore false positive only_used_in_recursion Clippy warning #15635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ignores a Clippy warning identified in #15625. Note, that this warning seems to be a false positive. I've submitted an issue with the Clippy project rust-lang/rust-clippy#14566. Ideally we'd get this fixed upstream instead of having to add this ignore directive.
Rationale for this change
As mentioned in #15625 (review), we get a Clippy warning
when linting the
datafusion-physical-optimizer
crate:cargo clippy -p datafusion-physical-optimizer
.What changes are included in this PR?
No real change was possible, so I added an ignore directive.
Clippy suggests to prefix the
config
parameter with an underscore but it is still used in the function body to pass it to recursive calls. Removing the parameter was also not an option because it is defined on thePhysicalOptimizerRule
trait and other implementations use it.Are these changes tested?
Running
cargo clippy -p datafusion-physical-optimizer
now reports no warnings.Are there any user-facing changes?
No, no actual code change.