Fix: Snowflake ALTER SESSION cannot be followed by other statements. #1786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#1775. Currently parse_session_options does not check for semicolons, which makes it impossible to parse multiple statements, where a statement comes after ALTER SESSION. Furthermore, it seems we should not advance the parser onto the semicolon as it is otherwise skipped in the next loop iteration of parse_statements() where the parser advances to the next token, which would then result in "Expected end of statement".
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
…pache#1786) Co-authored-by: Roman Borschel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1775.
Currently
parse_session_optionsfor Snowflake does not check for semicolons, which makes it impossible to parse multiple statements, where another statement comes after anALTER SESSIONstatement.