Skip to content

fix(ios): Prevent mix build phases #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2024
Merged

fix(ios): Prevent mix build phases #933

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e78e70a
fix(addHelper): Apply plugins sort from package.json
MaximBelov Oct 17, 2024
5220a2a
fix lint error
MaximBelov Oct 17, 2024
0c6fbb8
fix unit tests
MaximBelov Oct 18, 2024
c19a3a0
fix e2e tests
MaximBelov Oct 18, 2024
fc30726
fix coverage
MaximBelov Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cordova/platform/addHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,9 +290,14 @@ function installPluginsForNewPlatform (platform, projectRoot, opts) {

// Get a list of all currently installed plugins, ignoring those that have already been installed for this platform
// during prepare (installed from config.xml).
// Apply plugins sort from package.json
const platformJson = PlatformJson.load(plugins_dir, platform);
const pkgJson = readPackageJsonIfExists(projectRoot);
const pkgJsonCordovaPlugins = Object.keys(pkgJson.cordova.plugins);
const plugins = cordova_util.findPlugins(plugins_dir).filter(function (plugin) {
return !platformJson.isPluginInstalled(plugin);
}).sort(function (a, b) {
return pkgJsonCordovaPlugins.indexOf(a) - pkgJsonCordovaPlugins.indexOf(b);
});
if (plugins.length === 0) {
return Promise.resolve();
Expand Down
Loading