Skip to content

Update SQLite plugin details #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nikhilkh
Copy link
Contributor

@brodybits to help review.

@brody4hire
Copy link

I don't think "relies on native SQLite implementation" is so relevant anymore. The cordova-sqlite-storage version now includes its own sqlite3 implementation. Also yours truly (@brodybits) broke the cordova-sqlite-storage README link.

For the README links, would it be an idea to consider using "#readme" at the end of the repo link instead of hardcoding the link through the default branch name?

FYI other changes may be coming:

  • An "express-core" version that would use the built-in sqlite libraries for Android and iOS (not sure if we should really link this)
  • The default branch of the SQLCipher version (for which there is no link) will probably change
  • I may move or rename the "evfree" version.

In the past I would maintain the plugin source code in separate branches and publish a "*-master" branch that would also include the sqlite3 source/library dependencies. I changed cordova-sqlite-storage and cordova-sqlite-ext to fetch the sqlite3 source/library dependencies from npm (as discussed in apache/cordova-discuss#38) and published them from lighter-weight branches. I expect to do the same for the SQLCipher and "evfree" versions.

@brody4hire
Copy link

The updates look good to me, thanks!

FYI I dropped the Cordova engine constraint on Cordova-sqlite-storage.

@asfgit asfgit closed this in e646b07 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants