CB-11279 Support arbitrary repositories for 'coho nightly' #122
Conversation
| } | ||
| yield repoutil.forEachRepo(reposToBuild, function*(repo) { | ||
| var packageJSONPath = path.join(process.cwd(), 'package.json'); | ||
| var packageJSON = require(packageJSONPath); |
There was a problem hiding this comment.
For platform repos we maintain other files that have the version as well - like for cordova-android there is the VERSION file. How and when will they get updated? Perhaps at some point we should fix that to only use package.json for versions.
There was a problem hiding this comment.
Also, there is the version script too - I believe coho has methods to update the version. For now we might have to just use them. But we should file a JIRA to clean that up to reduce to one source of version from package.json
There was a problem hiding this comment.
So do the other places where the version is stored - not need to be updated with the nightly version?
There was a problem hiding this comment.
They now get updated by versionutil.updateRepoVersion - it handles all possible places, where version needs to be written to (see https://github.com/apache/cordova-coho/pull/122/files#diff-91127a766407aac9c0bc1bf9da171917R75) This method was a part of platform-release module before but i decided to move it to versionutil as it is IMO more appropriate place.
- Append new line to every package.json written - Use 2 spaces indent in 'package.json' as npm does
| } else { | ||
| packageJSON.dependencies['cordova-lib'] = cordovaLibVersion; | ||
| } | ||
| var packageJSONPath = path.join(process.cwd(), 'package.json'); |
There was a problem hiding this comment.
Looks like updateRepoVersion already updates package.json - you can probably remove the code here.
There was a problem hiding this comment.
We still need to update dependencies in package.json in case if we're releasing both dependent package and its dependency (e.g. cordova-lib and cordova-common), so the code is still required.
Anyway this code will be updated in the next PR that adds more robust support for platforms nightly releases
|
One minor comment - LGTM otherwise |
This PR adds the following features to
coho nightlycommand:--repoflag to specify repos to build nightlies for (instead of using predefined repos) . If--repois not specified, cordova-cli and cordova-lib will be built.nightlytag gracefully