CB-7904 Built nightly releases using coho #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var cordovaLibVersion; | ||
| //update package.json version for cli + lib, update lib reference for cli | ||
| yield repoutil.forEachRepo([cordovaLib, cli], function*(repo) { | ||
| var dir = process.cwd(); | ||
| var packageJSON = require(dir+'/package.json'); | ||
| packageJSON.version = versionutil.removeDev(packageJSON.version) + nightlyVersion; | ||
| packageJSON.version = versionutil.removeDev(packageJSON.version) + nightlyVersion + | ||
| '+' + SHAJSON[repo.id]; |
There was a problem hiding this comment.
should this use short SHA instead of the full SHA. Shorter makes it easier to read etc.
There was a problem hiding this comment.
Generally, eight to ten characters are more than enough to be unique within a project
(from Git book). I guess stripping to 8 characters should be enough for our purposes
|
LGTM otherwise |
| var oldNightlyVersions = {}; | ||
| oldNightlyVersions.cli = yield executil.execHelper(executil.ARGS('npm view cordova dist-tags.nightly')); | ||
| oldNightlyVersions.lib = yield executil.execHelper(executil.ARGS('npm view cordova-lib dist-tags.nightly')); | ||
| console.log('oldNightlyVersions: ' + JSON.stringify(oldNightlyVersions)); |
There was a problem hiding this comment.
Please use apputil.print to make logging consistent. Also could you please update this to print human-readable output instead of raw JSON
There was a problem hiding this comment.
OK, will this work?
apputil.print('oldNightlyVersions: ' + JSON.stringify(oldNightlyVersions, null, 4));
|
LGTM |
Ensure fetch and cli is properly installed/linked Add fetch to list of tools repos Resolve cordova-fetch location properly when npm-linking modules
Updates code for the current version Fixed the date format Add 'ignore-test-failures' flag for debugging purposes Clone repos if necessary before updating Add commit short SHA to the lib/cli build version Adds handling for separate CLI and LIB nightly versions unpublishing Fixes npm-unpublish-nightly entryPoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CB-7904 Built nightly releases using coho
Updates code for the current version
Fixed the date format
Add 'ignore-test-failures' flag for debugging purposes
Clone repos if necessary before updating
Add lib commit SHA to the build version
Adds handling for separate CLI and LIB nightly versions unpublishing
Fixes npm-unpublish-nightly entryPoint
CB-9858 Implement Cordova Fetch Proposal
Ensure fetch and cli is properly installed/linked
Add fetch to list of tools repos
Resolve cordova-fetch location properly when npm-linking modules
Jira issue