Minor naming changes in Shared FileSystems 4.20 Feature

[abh1sar]

Description

This PR fixes..

1. Change the UI tab name from Shared FIlesystem to Shared FileSystems
2. Rename Shared FileSystem VM to Shared FileSystem Instance
3. Remove create view table from schema-41910to42000 as it is not required.

Companion doc PR : apache/cloudstack-documentation#435

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 15.81%. Comparing base (679ce1a) to head (51c765b).
Report is 25 commits behind head on main.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	7 Missing ⚠️
...rg/apache/cloudstack/backup/BackupManagerImpl.java	0.00%	4 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	2 Missing and 1 partial ⚠️
...n/java/com/cloud/template/TemplateManagerImpl.java	0.00%	1 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	0.00%	1 Missing ⚠️
.../cloudstack/affinity/AffinityGroupServiceImpl.java	0.00%	1 Missing ⚠️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9675      +/-   ##
============================================
+ Coverage     15.76%   15.81%   +0.05%     
- Complexity    12507    12554      +47     
============================================
  Files          5619     5629      +10     
  Lines        491158   492029     +871     
  Branches      62973    61647    -1326     
============================================
+ Hits          77419    77812     +393     
- Misses       405283   405893     +610     
+ Partials       8456     8324     -132     

Flag	Coverage Δ
uitests	4.48% <ø> (+0.42%)	⬆️
unittests	16.60% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11104

[abh1sar]

@blueorangutan test

[blueorangutan]

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[sureshanaparti]

clgtm

[abh1sar]

@JoaoJandre @rohityadavcloud
This PR contains some minor cosmetic changes related to naming conventions for the Shared FileSystems feature we are shipping in 4.20. But I think it has high impact in terms of user experience and clarity.
For example,

• it is little jarring to see 'Shared FileSystem' as the only tab which is singular in UI. All other tabs ('Volumes', 'Snapshots' etc) are plural.
• Cloudstack has the convention of calling user VM Instances, which we should maintain for Shared Filesystems VM as well.

The other small change is to just remove the user_vm_view definition from upgrade path, as we have separate files for creating views.

Can we please include this in 4.20.0?

[rohityadavcloud]

@abh1sar as long as this is reviewed and tested, I think it's okay but since freeze is declared - it's upto our release manager @JoaoJandre to review and approve/merge.

I like that we've dropped the unnecessary views changes as they're not kept in separate file, LGTM overall.

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

verified OK, no issues found

[borisstoyanov]

@blueorangutan ui

[blueorangutan]

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9675 (QA-JID-446)

[borisstoyanov]

LGTM

[JoaoJandre]

CLGTM. As this PR is just renaming some things and removing the duplicated view definition, I think we can include it.

[blueorangutan]

[SF] Trillian test result (tid-11465)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55009 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9675-t11465-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	Failure	455.63	test_vpc_vpn.py

[blueorangutan]

[SF] Trillian test result (tid-11466)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52358 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9675-t11466-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File