pre-commit: add hook `check-yaml` #9133

jbampton · 2024-05-28T14:32:15Z

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml

Description

This PR adds another check or test to our pre-commit framework.

From the official pre-commit organization.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally:

pre-commit run --all-files

How did you try to break this feature and the system with this change?

codecov · 2024-05-28T14:42:09Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (b48de4e) to head (58dfd88).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #9133   +/-   ##
=========================================
  Coverage     16.06%   16.06%           
- Complexity    12871    12872    +1     
=========================================
  Files          5642     5642           
  Lines        493973   493973           
  Branches      59895    59895           
=========================================
+ Hits          79348    79351    +3     
+ Misses       405839   405837    -2     
+ Partials       8786     8785    -1

Flag	Coverage Δ
uitests	`4.01% <ø> (ø)`
unittests	`16.90% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.pre-commit-config.yaml

plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-node.yml

jbampton · 2024-07-08T02:20:32Z

@blueorangutan package

blueorangutan · 2024-07-08T02:22:03Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-08T03:32:59Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10279

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml

jbampton · 2024-10-14T12:41:38Z

@blueorangutan package

blueorangutan · 2024-10-14T12:42:04Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-14T14:01:49Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11334

DaanHoogland

clgtm

vishesh92 · 2024-10-25T04:52:35Z

@blueorangutan test

vishesh92

clgtm. can be merged once the tests passes.

DaanHoogland · 2024-10-28T15:59:41Z

@blueorangutan package

blueorangutan · 2024-10-28T16:02:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-10-28T16:30:56Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11460

blueorangutan · 2024-10-29T09:59:18Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11466

jbampton · 2024-12-20T22:01:55Z

@blueorangutan package

blueorangutan · 2024-12-20T22:04:07Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-20T23:44:14Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11870

jbampton · 2024-12-28T09:16:37Z

@blueorangutan package

blueorangutan · 2024-12-28T09:18:04Z

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-12-28T10:26:54Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11928

DaanHoogland · 2024-12-28T11:12:29Z

@blueorangutan test

blueorangutan · 2024-12-28T11:14:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-29T18:25:22Z

[SF] Trillian test result (tid-12001)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 109701 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9133-t12001-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3643.80	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3647.44	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3651.16	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	3639.69	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	3638.84	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	3645.39	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3669.90	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	3702.86	test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn	`Failure`	457.66	test_vpc_vpn.py

DaanHoogland · 2024-12-29T20:32:37Z

@blueorangutan test

blueorangutan · 2024-12-29T20:34:06Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-12-31T04:05:15Z

[SF] Trillian test result (tid-12003)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 111134 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9133-t12003-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3648.09	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3650.24	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	3653.89	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	3649.40	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	3653.54	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	3638.83	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3675.58	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	3708.02	test_kubernetes_clusters.py

nvazquez · 2025-01-04T04:17:17Z

Hi guys @jbampton @DaanHoogland @vishesh92 I'm not able to get CKS clusters into Running state after these changes (at least after merging main branch on my PR #9102):

Accessing one of the CKS nodes I could check there were syntax errors which I could work around by reverting this PR changes. I haven't tried on the current main branch yet but I suspect the same issue could be present there

DaanHoogland · 2025-01-04T07:21:33Z

Sorry @nvazquez , I was a bit eager on this one, let's revert. cc @vishesh92
@jbampton @nvazquez , do you see a possibility to make this check work (by options on the check or a syntax change in the yamls)?

This reverts commit 57867dc.

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml

This reverts commit 57867dc.

This reverts commit d1cf453.

DaanHoogland reviewed May 29, 2024

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

boring-cyborg bot added the component:kubernetes label May 29, 2024

jbampton commented May 29, 2024

View reviewed changes

plugins/integrations/kubernetes-service/src/main/resources/conf/k8s-node.yml Outdated Show resolved Hide resolved

DaanHoogland closed this Jun 3, 2024

DaanHoogland reopened this Jun 3, 2024

DaanHoogland approved these changes Jul 8, 2024

View reviewed changes

pre-commit: add hook check-yaml

b1778cc

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml

jbampton force-pushed the pre-commit-check-yaml branch from 8ecc0e1 to b1778cc Compare October 14, 2024 11:59

jbampton requested review from vishesh92 and DaanHoogland October 14, 2024 12:42

DaanHoogland approved these changes Oct 23, 2024

View reviewed changes

DaanHoogland closed this Oct 23, 2024

DaanHoogland reopened this Oct 23, 2024

vishesh92 approved these changes Oct 25, 2024

View reviewed changes

Merge branch 'main' into pre-commit-check-yaml

2e699aa

Merge branch 'main' into pre-commit-check-yaml

58dfd88

DaanHoogland merged commit 57867dc into apache:main Dec 31, 2024
26 checks passed

jbampton deleted the pre-commit-check-yaml branch December 31, 2024 11:59

DaanHoogland added a commit that referenced this pull request Jan 4, 2025

Revert "pre-commit: add hook check-yaml (#9133)"

61328bc

This reverts commit 57867dc.

DaanHoogland mentioned this pull request Jan 4, 2025

Revert "pre-commit: add hook check-yaml" #10161

Merged

weizhouapache pushed a commit that referenced this pull request Jan 6, 2025

Revert "pre-commit: add hook check-yaml (#9133)" (#10161)

d1cf453

This reverts commit 57867dc.

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 10, 2025

pre-commit: add hook check-yaml (apache#9133)

a539822

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-yaml

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jan 10, 2025

Revert "pre-commit: add hook check-yaml (apache#9133)" (apache#10161)

ccb3dc9

This reverts commit 57867dc.

abh1sar added a commit to abh1sar/cloudstack that referenced this pull request Jan 13, 2025

Reapply "pre-commit: add hook check-yaml (apache#9133)" (apache#10161)

8c1ca28

This reverts commit d1cf453.

pre-commit: add hook check-yaml #9133

pre-commit: add hook check-yaml #9133

Uh oh!

Conversation

jbampton commented May 28, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

jbampton commented Jul 8, 2024

Uh oh!

blueorangutan commented Jul 8, 2024

Uh oh!

blueorangutan commented Jul 8, 2024

Uh oh!

jbampton commented Oct 14, 2024

Uh oh!

blueorangutan commented Oct 14, 2024

Uh oh!

blueorangutan commented Oct 14, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Oct 25, 2024

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Oct 28, 2024

Uh oh!

blueorangutan commented Oct 28, 2024

Uh oh!

blueorangutan commented Oct 28, 2024

Uh oh!

blueorangutan commented Oct 29, 2024

Uh oh!

jbampton commented Dec 20, 2024

Uh oh!

blueorangutan commented Dec 20, 2024

Uh oh!

blueorangutan commented Dec 20, 2024

Uh oh!

jbampton commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

DaanHoogland commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 28, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

DaanHoogland commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 29, 2024

Uh oh!

blueorangutan commented Dec 31, 2024

Uh oh!

Uh oh!

nvazquez commented Jan 4, 2025

Uh oh!

DaanHoogland commented Jan 4, 2025

Uh oh!

Uh oh!

pre-commit: add hook `check-yaml` #9133

pre-commit: add hook `check-yaml` #9133

codecov bot commented May 28, 2024 •

edited

Loading