verify that when createTemplate is ued to create templates with same … #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name, all of them fet unique_name under vm_template table so that templates with same name does not get deleted during template sync
|
Test when createTemplate is used to create templates having the same name all of them get ... === TestName: test_CreateTemplateWithDuplicateName | Status : SUCCESS === Ran 1 test in 442.896s OK |
|
cloudstack-pull-rats #279 SUCCESS |
|
cloudstack-pull-requests #976 SUCCESS |
|
cloudstack-pull-analysis #212 SUCCESS |
|
LGTM |
|
Sanjeev N on [email protected] replies: |
|
LGTM |
|
Sanjeev, thanks! Can you please use the git merge script located in ./tools/git/git-pr? See: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655 |
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…name,
all of them fet unique_name under vm_template table so that templates with
same name does not get deleted during template sync