[VMware] Added Worker VM tags for few cloned VMs while performing some volume operations.

[sureshanaparti]

Description

Worker VM tags are missed for few cloned VMs in VMware, and so these are skipped when tracking / cleaning up of Worker VMs. Adding proper Worker VM tags to these VMs would make them trackable from CloudStack.

This PR updates the (missed) Worker VM tags for the cloned VMs (in VMware) when creating template from volume, and exporting volume to secondary storage.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

Snapshot operation (for detached disk) tasks in vCenter =>

Worker VM to attach disk =>

Cloned VM to export disk to secondary storage =>

How Has This Been Tested?

Manually verified the worker VM tags set in the cloned VMs (from vCenter) while performing the following operations.

• Take volume snapshot
• Create template from volume

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1021

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1781)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36593 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5377-t1781-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[rohityadavcloud]

@sureshanaparti does this affect 4.15? If so please change PR branch to 4.15 esp for bugfixes, thanks.

[nvazquez]

LGTM

[DaanHoogland]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1059

[sureshanaparti]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1836)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39415 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5377-t1836-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File