Skip to content

UI: Fix volumes SearchView #11168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

bernardodemarco
Copy link
Member

@bernardodemarco bernardodemarco commented Jul 9, 2025

Description

The SearchView component of the volumes page is currently performing an API call to listvolumes, and not to listVolumes. This is causing an error in the API request and, as a consequence, the zone, domain and account select fields of the form are not loading.

This PR fixes this bug.


Fixes #11167

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Before:
    image

  • After:
    image

@bernardodemarco bernardodemarco added this to the 4.20.2 milestone Jul 9, 2025
@bernardodemarco
Copy link
Member Author

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (80f46ad) to head (7117b61).
Report is 1 commits behind head on 4.20.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11168      +/-   ##
============================================
- Coverage     16.15%   16.15%   -0.01%     
+ Complexity    13269    13268       -1     
============================================
  Files          5657     5657              
  Lines        497772   497772              
  Branches      60364    60364              
============================================
- Hits          80414    80410       -4     
- Misses       408408   408413       +5     
+ Partials       8950     8949       -1     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11168 (QA-JID-661)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested in qa

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland DaanHoogland merged commit 1cbf1cd into apache:4.20 Jul 9, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants