server: fix conserve_mode of DefaultIsolatedNetworkOfferingForVpcNetworks

[weizhouapache]

Description

This PR fixes the conserve_mode of network offering DefaultIsolatedNetworkOfferingForVpcNetworks is still 0 in fresh installation

mysql> select conserve_mode  from `cloud`.`network_offerings` where name='DefaultIsolatedNetworkOfferingForVpcNetworks'\G
*************************** 1. row ***************************
conserve_mode: 0
1 row in set (0.00 sec)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

I am so sorry, this is the 3rd PR for the same issue

🤦

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.91%. Comparing base (be22bfe) to head (af3dead).
Report is 14 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (be22bfe) and HEAD (af3dead). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (be22bfe)	HEAD (af3dead)
unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #11133       +/-   ##
=============================================
- Coverage     16.57%    3.91%   -12.67%     
=============================================
  Files          5743      415     -5328     
  Lines        510648    33793   -476855     
  Branches      62105     6078    -56027     
=============================================
- Hits          84641     1322    -83319     
+ Misses       416534    32313   -384221     
+ Partials       9473      158     -9315     

Flag	Coverage Δ
uitests	3.91% <ø> (+<0.01%)	⬆️
unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

clgtm, and would this be the last one? ;)

[weizhouapache]

clgtm, and would this be the last one? ;)

hope so @DaanHoogland
😆

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14036

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13687)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52969 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11133-t13687-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[weizhouapache]

@blueorangutan package

[weizhouapache]

@DaanHoogland @sureshanaparti
I updated a smoke test to test the conserve mode, hope the issue will be fixed PERMANENTLY.