UI: Fix missing labels #11102
UI: Fix missing labels #11102
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing UI labels and corrects a label key in the Service Providers tab.
- Fixed the label key used for NSX providers in the Vue component.
- Added new translation entries for Tier-0 Gateway, Transport Zone, and Edge Cluster.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/src/views/infra/network/ServiceProvidersTab.vue | Updated the title key from label.nsx.controller to label.nsx.provider. |
| ui/public/locales/en.json | Added translation entries for label.tier0gateway, label.transportzone, and label.edgecluster. |
Comments suppressed due to low confidence (1)
ui/public/locales/en.json:2308
- [nitpick] The translation keys use concatenated naming (e.g.,
label.tier0gateway). For improved consistency and readability, consider a more structured key pattern (e.g.,label.nsx.tier0Gateway) and alphabetize new entries.
"label.tier0gateway": "Tier-0 Gateway",
| @@ -1118,7 +1118,7 @@ export default { | |||
| ], | |||
| lists: [ | |||
| { | |||
| title: 'label.nsx.controller', | |||
| title: 'label.nsx.provider', | |||
There was a problem hiding this comment.
The label key 'label.nsx.provider' isn’t defined in the locales, so it will render as a missing translation at runtime. Please add an entry to ui/public/locales/en.json, for example: "label.nsx.provider": "NSX Provider".
Copilot uses AI. Check for mistakes.
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11102 +/- ##
=========================================
Coverage 16.15% 16.15%
Complexity 13277 13277
=========================================
Files 5657 5657
Lines 497939 497939
Branches 60386 60386
=========================================
Hits 80443 80443
Misses 408532 408532
Partials 8964 8964
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
Description
This PR adds missing labels
Before Fix:
After fix:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?