server: fix orphan db transaction issue

[shwstppr]

Description

Fixes #11058

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (ba0204f) to head (98d0e57).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11095   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
  Complexity    13277    13277           
=========================================
  Files          5657     5657           
  Lines        497939   497942    +3     
  Branches      60386    60386           
=========================================
+ Hits          80443    80446    +3     
+ Misses       408532   408531    -1     
- Partials       8964     8965    +1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.00% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vishesh92]

clgtm. tested locally. I no longer see the orphaned transaction errors.

[DaanHoogland]

clgtm

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13939

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13623)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58801 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13623-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_Iso	Failure	128.41	test_iso.py

[DaanHoogland]

I don’t think the iso error is related, invesitgating, and also to verify the absence of the orphaned connection messages;
@blueorangutan test keepEnv

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests