api: fix scale or upgrade systemvm

[weizhouapache]

Description

This PR fixes an issue when scale systemvm, when "allow.diskoffering.change.during.scale.vm" is set to "true"

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (0d5a0ea) to head (660eef7).
Report is 1 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...k/api/command/admin/systemvm/ScaleSystemVMCmd.java	0.00%	1 Missing ⚠️
...api/command/admin/systemvm/UpgradeSystemVMCmd.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #11062      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
+ Complexity    11365    11363       -2     
============================================
  Files          5416     5416              
  Lines        475890   475911      +21     
  Branches      58093    58096       +3     
============================================
- Hits          72254    72238      -16     
- Misses       395550   395586      +36     
- Partials       8086     8087       +1     

Flag	Coverage Δ
uitests	4.28% <ø> (ø)
unittests	15.90% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13912

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13602)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48039 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11062-t13602-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File