Skip to content

Allow populating generic templates during Zone Deployment #10947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Jun 3, 2025

Description

This PR will provide optional step during Zone deployment for admin to register generic cloud templates. This step will be available for KVM hypervisor and limited number of x86_64 and arm64 templates will be supported for now.

Doc pr: apache/cloudstack-documentation#525

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2025-06-18 18-10-31

Zone details, add resource steps are disabled to show Register template.

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 requested a review from shwstppr June 3, 2025 04:29
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (7632814) to head (39435e5).
Report is 53 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main   #10947     +/-   ##
===========================================
  Coverage     16.57%   16.57%             
- Complexity    13868    13988    +120     
===========================================
  Files          5719     5744     +25     
  Lines        507178   510803   +3625     
  Branches      61571    62134    +563     
===========================================
+ Hits          84085    84691    +606     
- Misses       413674   416639   +2965     
- Partials       9419     9473     +54     
Flag Coverage Δ
uitests 3.89% <ø> (-0.08%) ⬇️
unittests 17.48% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohityadavcloud rohityadavcloud added this to the 4.21.0 milestone Jun 3, 2025
@sudo87
Copy link
Collaborator Author

sudo87 commented Jun 13, 2025

@weizhouapache Generic templates are hosted in cloudstack cdn to ensure availability and no redirection anymore. Latest changes are pushed to use these urls.

Templates are hosted at: https://download.cloudstack.org/templates/cloud-images/

@sudo87
Copy link
Collaborator Author

sudo87 commented Jun 13, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13762

@sudo87
Copy link
Collaborator Author

sudo87 commented Jun 19, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13838

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13565)

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

not tested yet

@weizhouapache
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10947 (QA-JID-650)

@sudo87
Copy link
Collaborator Author

sudo87 commented Jun 20, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13851

@sudo87
Copy link
Collaborator Author

sudo87 commented Jul 2, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13984

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10947 (QA-JID-658)

@DaanHoogland
Copy link
Contributor

@sudo87 , I see only UI code. Any reason why this would not be visible in qa?

@sudo87
Copy link
Collaborator Author

sudo87 commented Jul 3, 2025

It gets enabled only for KVM hypervisor, took the screenshot from qa:

image

@sudo87
Copy link
Collaborator Author

sudo87 commented Jul 4, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14024

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested with zone creation wizard for Edge, Basic and Advanced zone

The register cloud image options comes after zone is enabled .

The template are also displayed based on the architecture type of the cluster

Screenshot 2025-07-02 at 6 17 35 PM

@DaanHoogland
Copy link
Contributor

@rohityadavcloud are you ok with this now?

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14089

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

7 participants