Skip to content

[DO NOT MERGE - TEST] Revert "Rollback of changes with errors during the VM assign" #10851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shwstppr
Copy link
Contributor

Reverts #7061

Failures seen in GHA. This is to verify that the revert fixes them.

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 2.18750% with 313 lines in your changes missing coverage. Please review.

Project coverage is 16.07%. Comparing base (011fced) to head (734ce3c).
Report is 5 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 2.27% 293 Missing and 8 partials ⚠️
...e/cloudstack/api/command/admin/vm/AssignVMCmd.java 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #10851      +/-   ##
============================================
- Coverage     16.13%   16.07%   -0.07%     
+ Complexity    13225    13146      -79     
============================================
  Files          5652     5652              
  Lines        497021   496973      -48     
  Branches      60222    60251      +29     
============================================
- Hits          80202    79870     -332     
- Misses       407885   408159     +274     
- Partials       8934     8944      +10     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.91% <2.18%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
4.9% Coverage on New Code (required ≥ 40%)
26.4% Duplication on New Code (required ≤ 10%)
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@shwstppr shwstppr closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant