Refactor Quota Summary API #10505

julien-vaz · 2025-03-05T13:42:16Z

Description

The quotaSummary API has abstract behaviors and codes, as well as return values not aligned with its purposes. Furthermore, when the account is a project, no information is returned.

Also, in the UI, when opening the Quota Summary details for accounts who owned removed domains, the CloudStack launches an error to the user.

Therefore, this PR:

improves the API's behavior and return values;
adds information for project accounts (through parameter listall=true);
adds information for accounts/domains which have been already removed and a filter for accounts in the UI;

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

On CloudMonkey I called quotaSummary API and checked the return value:

only relevant information about the summaries is being displayed;
accounts and domains which have been removed are especified in the summary;
project accounts are also being considered by the API.

On the UI, the filter for removed accounts is working properly.

julien-vaz · 2025-03-05T13:50:09Z

@blueorangutan package

blueorangutan · 2025-03-05T13:52:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-05T14:12:33Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12665

codecov · 2025-03-05T21:05:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.91%. Comparing base (3a28a87) to head (4d3ad22).
Report is 293 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3a28a87) and HEAD (4d3ad22). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (3a28a87) HEAD (4d3ad22)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               main   #10505       +/-   ##
=============================================
- Coverage     16.15%    3.91%   -12.25%     
=============================================
  Files          5666      415     -5251     
  Lines        498081    33793   -464288     
  Branches      60267     6078    -54189     
=============================================
- Hits          80475     1322    -79153     
+ Misses       408593    32313   -376280     
+ Partials       9013      158     -8855

Flag	Coverage Δ
uitests	`3.91% <ø> (-0.09%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

julien-vaz · 2025-03-06T17:30:25Z

@blueorangutan package

blueorangutan · 2025-03-06T17:32:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-06T17:59:03Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12690

julien-vaz · 2025-03-11T15:45:34Z

I've just successfully builded the packages locally with -Dnoredist. Therefore, I'm requesting the package building again

julien-vaz · 2025-03-11T15:45:49Z

@blueorangutan package

blueorangutan · 2025-03-11T15:46:05Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-11T16:37:19Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12739

julien-vaz · 2025-03-11T17:05:44Z

@blueorangutan package

blueorangutan · 2025-03-11T17:08:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-11T18:22:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12743

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

…/command/QuotaSummaryCmd.java Co-authored-by: Fabricio Duarte <[email protected]>

sureshanaparti · 2025-06-05T09:25:19Z

@blueorangutan package

blueorangutan · 2025-06-05T09:26:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

julien-vaz · 2025-06-09T17:00:24Z

@blueorangutan package

blueorangutan · 2025-06-09T17:02:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-09T18:02:46Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13679

rohityadavcloud · 2025-06-10T08:15:37Z

@blueorangutan test

blueorangutan · 2025-06-10T08:16:03Z

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-06-11T01:18:14Z

[SF] Trillian test result (tid-13486)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58393 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10505-t13486-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

winterhazel · 2025-07-01T18:00:24Z

@blueorangutan package

blueorangutan · 2025-07-01T18:02:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-01T18:24:08Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13969

julien-vaz · 2025-07-02T17:59:18Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13969

I've just built the packages locally, so I'm triggering the Blue Orangutan again

julien-vaz · 2025-07-02T17:59:29Z

@blueorangutan package

blueorangutan · 2025-07-02T18:00:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-02T20:33:26Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13993

blueorangutan · 2025-07-03T08:42:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13998

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java

...ns/database/quota/src/main/java/org/apache/cloudstack/api/response/QuotaSummaryResponse.java

…/command/QuotaSummaryCmd.java Co-authored-by: dahn <[email protected]>

winterhazel

@julien-vaz when an admin calls quota summary listall=true, only information about the system account is being returned. It would make more sense to return information about all the accessible accounts instead.

julien-vaz · 2025-07-10T16:39:51Z

@blueorangutan package

blueorangutan · 2025-07-10T16:42:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-10T17:05:48Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14131

julien-vaz · 2025-07-11T17:45:23Z

@blueorangutan package

blueorangutan · 2025-07-11T17:46:03Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-11T19:02:50Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14140

Refactor Quota Summary API

115d303

boring-cyborg bot added component:api component:quota labels Mar 5, 2025

winterhazel added this to the 4.21.0 milestone Mar 5, 2025

winterhazel self-requested a review March 6, 2025 13:06

Fixes imports

36fe76e

Fix QuotaServiceImplTest

6897eeb

winterhazel requested changes Apr 8, 2025

View reviewed changes

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java Outdated Show resolved Hide resolved

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java Outdated Show resolved Hide resolved

Update plugins/database/quota/src/main/java/org/apache/cloudstack/api…

87feb02

…/command/QuotaSummaryCmd.java Co-authored-by: Fabricio Duarte <[email protected]>

bernardodemarco self-requested a review June 4, 2025 17:39

Fix QuotaSummaryCmd

1dcfbbf

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti requested a review from DaanHoogland June 5, 2025 09:25

winterhazel reviewed Jul 1, 2025

View reviewed changes

plugins/database/quota/src/main/java/org/apache/cloudstack/api/command/QuotaSummaryCmd.java Show resolved Hide resolved

Remove unused createQuotaSummaryResponse declarations

1cceb81

Remove unnecessary imports

e723223

DaanHoogland reviewed Jul 3, 2025

View reviewed changes

winterhazel self-requested a review July 8, 2025 17:17

Update plugins/database/quota/src/main/java/org/apache/cloudstack/api…

2800239

…/command/QuotaSummaryCmd.java Co-authored-by: dahn <[email protected]>

winterhazel requested changes Jul 9, 2025

View reviewed changes

Fix QuotaSummaryCmd

4d3ad22

Julien Hervot de Mattos Vaz added 2 commits July 11, 2025 14:33

Fix QuotaResponseBuilderImplTest

34fb78b

Refactor test

b4db390

Refactor Quota Summary API #10505

Are you sure you want to change the base?

Refactor Quota Summary API #10505

Uh oh!

Conversation

julien-vaz commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

julien-vaz commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

blueorangutan commented Mar 5, 2025

Uh oh!

codecov bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

julien-vaz commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

julien-vaz commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

julien-vaz commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

blueorangutan commented Mar 11, 2025

Uh oh!

Uh oh!

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

julien-vaz commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

rohityadavcloud commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 11, 2025

Uh oh!

Uh oh!

winterhazel commented Jul 1, 2025

Uh oh!

blueorangutan commented Jul 1, 2025

Uh oh!

blueorangutan commented Jul 1, 2025

Uh oh!

julien-vaz commented Jul 2, 2025

Uh oh!

julien-vaz commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

Uh oh!

julien-vaz commented Mar 5, 2025 •

edited

Loading

codecov bot commented Mar 5, 2025 •

edited

Loading

julien-vaz commented Mar 11, 2025 •

edited

Loading