Add logs for storage pools reordering #10419

julien-vaz · 2025-02-18T14:12:26Z

Description

Since the storage pool reordering process was lacking logs for troubleshooting, some debug level log messages were added and trace level log messages were changed to the debug level. Also, the log messages were rewritten according to the new Log4j2 syntax.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

A volume was created;
Its disk offering was changed;
It was verified that the log messages were properly being displayed.

boring-cyborg · 2025-02-18T14:12:31Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

codecov · 2025-02-18T15:14:51Z

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (fa85a75) to head (b69581a).
Report is 58 commits behind head on main.

Files with missing lines	Patch %	Lines
...torage/allocator/AbstractStoragePoolAllocator.java	20.00%	24 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10419      +/-   ##
============================================
- Coverage     16.58%   16.57%   -0.01%     
- Complexity    13870    13987     +117     
============================================
  Files          5719     5745      +26     
  Lines        507194   510845    +3651     
  Branches      61573    62136     +563     
============================================
+ Hits          84093    84697     +604     
- Misses       413681   416676    +2995     
- Partials       9420     9472      +52

Flag	Coverage Δ
uitests	`3.91% <ø> (-0.06%)`	⬇️
unittests	`17.47% <20.00%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java

DaanHoogland

one general remark on these changes; I see only trace and debug logs, but if axtra logs are really needed I would expect at least hight level logging to be added (info and higher) were considerations made to do this? (DEBUG should not be on in production environments in principle, unless trouble shooting is going on)

julien-vaz · 2025-03-05T16:41:13Z

Alright, I've just changed the level of logs on reordering methods, @DaanHoogland

DaanHoogland

makes mostly sense, just one info i'd like to question.

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java

julien-vaz · 2025-03-06T17:32:14Z

@blueorangutan package

blueorangutan · 2025-03-06T17:34:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-06T18:46:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12691

DaanHoogland

clgtm

bernardodemarco

clgtm

github-actions · 2025-05-16T16:35:37Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2025-06-02T20:03:39Z

@julien-vaz could you fix the conflicts?

julien-vaz · 2025-06-04T17:21:28Z

@julien-vaz could you fix the conflicts?

Sure!

Substitui por nova sintaxe do Log4j

…ocator/AbstractStoragePoolAllocator.java Co-authored-by: dahn <[email protected]>

sureshanaparti · 2025-06-05T09:31:34Z

@blueorangutan package

blueorangutan · 2025-06-05T09:32:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-05T11:54:33Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13617

DaanHoogland · 2025-06-09T12:59:46Z

@blueorangutan test

blueorangutan · 2025-06-09T13:02:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-06-10T05:55:21Z

[SF] Trillian test result (tid-13481)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13481-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-06-11T17:43:17Z

@sureshanaparti , do you think we need anymore testing on this? (/me not convinced)

julien-vaz · 2025-06-23T14:24:55Z

I've just built the packages locally, so I'm triggering the Blue Orangutan again.

julien-vaz · 2025-06-23T14:25:09Z

@blueorangutan package

blueorangutan · 2025-06-23T14:26:04Z

@julien-vaz a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland · 2025-06-23T14:44:30Z

I've just built the packages locally, so I'm triggering the Blue Orangutan again.

why do you think this is needed @julien-vaz ?

blueorangutan · 2025-06-23T15:39:19Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13881

julien-vaz · 2025-07-02T17:33:10Z

I've just built the packages locally, so I'm triggering the Blue Orangutan again.

why do you think this is needed @julien-vaz ?

Because the debian build has failed previously

DaanHoogland · 2025-07-02T18:39:36Z

why do you think this is needed @julien-vaz ?

Because the debian build has failed previously

ok, nothing related to your changes but now you asked for it ;)
@blueorangutan test ubuntu22 kvm-ubuntu22 keepEnv

blueorangutan · 2025-07-02T18:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests

blueorangutan · 2025-07-03T12:21:05Z

[SF] Trillian test result (tid-13665)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 61144 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10419-t13665-kvm-ubuntu22.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java

DaanHoogland · 2025-07-03T13:51:02Z

sorry @julien-vaz , I did some greps on the logs and it all looks fine.

…ocator/AbstractStoragePoolAllocator.java Co-authored-by: dahn <[email protected]>

DaanHoogland · 2025-07-14T05:46:39Z

@blueorangutan package

blueorangutan · 2025-07-14T05:48:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-14T06:54:57Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14158

boring-cyborg bot added the component:storage label Feb 18, 2025

bernardodemarco reviewed Mar 1, 2025

View reviewed changes

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java Outdated Show resolved Hide resolved

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java Outdated Show resolved Hide resolved

DaanHoogland reviewed Mar 3, 2025

View reviewed changes

DaanHoogland reviewed Mar 6, 2025

View reviewed changes

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java Outdated Show resolved Hide resolved

DaanHoogland approved these changes Mar 7, 2025

View reviewed changes

bernardodemarco approved these changes Apr 7, 2025

View reviewed changes

github-actions bot added the status:has-conflicts label May 16, 2025

Julien Hervot de Mattos Vaz and others added 3 commits June 4, 2025 18:17

Adição de logs na reordenação de storage pools

2f2dafa

Substitui por nova sintaxe do Log4j

Apply suggestions

f0186a6

Update engine/storage/src/main/java/org/apache/cloudstack/storage/all…

04e69aa

…ocator/AbstractStoragePoolAllocator.java Co-authored-by: dahn <[email protected]>

julien-vaz force-pushed the add-logs-storage-pool-reordering branch from 53c59bf to 04e69aa Compare June 4, 2025 21:26

github-actions bot removed the status:has-conflicts label Jun 4, 2025

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

DaanHoogland added the status:needs-testing label Jun 23, 2025

DaanHoogland reviewed Jul 3, 2025

View reviewed changes

...rage/src/main/java/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java Outdated Show resolved Hide resolved

Update engine/storage/src/main/java/org/apache/cloudstack/storage/all…

b69581a

…ocator/AbstractStoragePoolAllocator.java Co-authored-by: dahn <[email protected]>

Add logs for storage pools reordering #10419

Are you sure you want to change the base?

Add logs for storage pools reordering #10419

Conversation

julien-vaz commented Feb 18, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

boring-cyborg bot commented Feb 18, 2025

Uh oh!

codecov bot commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

julien-vaz commented Mar 5, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

julien-vaz commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

JoaoJandre commented Jun 2, 2025

Uh oh!

julien-vaz commented Jun 4, 2025

Uh oh!

sureshanaparti commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

blueorangutan commented Jun 5, 2025

Uh oh!

DaanHoogland commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 9, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

DaanHoogland commented Jun 11, 2025

Uh oh!

julien-vaz commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

julien-vaz commented Jun 23, 2025

Uh oh!

blueorangutan commented Jun 23, 2025

Uh oh!

DaanHoogland commented Jun 23, 2025

Uh oh!

blueorangutan commented Jun 23, 2025

Uh oh!

julien-vaz commented Jul 2, 2025

Uh oh!

DaanHoogland commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 3, 2025

Uh oh!

Uh oh!

codecov bot commented Feb 18, 2025 •

edited

Loading

julien-vaz commented Jun 23, 2025 •

edited

Loading