Skip to content

[UI] Switch between allocated and used capacity on dashboard #10215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2025
Merged

[UI] Switch between allocated and used capacity on dashboard #10215

merged 4 commits into from
Jan 23, 2025

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jan 20, 2025 •
edited
Loading

Description

This PR fixes the UI display of used vs allocated resources. It adds a switch to display allocated or used resources

Screen.Recording.2025-01-20.at.13.15.13.mov

Fixes: #10185

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez nvazquez added this to the 4.19.2 milestone Jan 20, 2025
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland reopened this Jan 20, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (9967bb3) to head (fa90e52).
Report is 13 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10215      +/-   ##
============================================
+ Coverage     15.13%   15.14%   +0.01%     
- Complexity    11274    11286      +12     
============================================
  Files          5408     5408              
  Lines        473974   473822     -152     
  Branches      57813    57825      +12     
============================================
+ Hits          71730    71775      +45     
+ Misses       394227   394023     -204     
- Partials       8017     8024       +7
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.87% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10215 (QA-JID-513)

@nvazquez nvazquez linked an issue Jan 20, 2025 that may be closed by this pull request
[UI] Metris calculations mismatch - Allocated vs Used #10185
Closed
@nvazquez
Copy link
Contributor Author

@blueorangutan ui

1 similar comment
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10215 (QA-JID-515)

DaanHoogland
DaanHoogland approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm and tested in qa

@DaanHoogland DaanHoogland reopened this Jan 20, 2025
Pearl1594
Pearl1594 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but have a small comment for better readability

@nvazquez
Copy link
Contributor Author

Fixed - thanks @Pearl1594 !

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10215 (QA-JID-523)

@DaanHoogland
Copy link
Contributor

still works 👍

@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10215 (QA-JID-528)

@nvazquez nvazquez merged commit c9fea62 into apache:4.19 Jan 23, 2025
25 of 26 checks passed
@nvazquez nvazquez deleted the fix-ui-allocated-vs-used branch January 23, 2025 14:06
@nvazquez nvazquez mentioned this pull request Jan 23, 2025
Closed
rg9975 pushed a commit to rg9975/cloudstack that referenced this pull request Jan 31, 2025
@nvazquez
[UI] Switch between allocated and used capacity on dashboard (apache#…
fe03bb7 
…10215)

* [UI] Switch between allocated and used capacity on dashboard

* Fix text

* Refactor

* Internationalize capacity text
@nvazquez nvazquez mentioned this pull request May 3, 2025
Open
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@nvazquez @dhslove
[UI] Switch between allocated and used capacity on dashboard (apache#…
e320cae 
…10215)

* [UI] Switch between allocated and used capacity on dashboard

* Fix text

* Refactor

* Internationalize capacity text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@rohityadavcloud rohityadavcloud Awaiting requested review from rohityadavcloud

@shwstppr shwstppr Awaiting requested review from shwstppr

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@vladimirpetrov vladimirpetrov Awaiting requested review from vladimirpetrov

@borisstoyanov borisstoyanov Awaiting requested review from borisstoyanov

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees
No one assigned
Labels
component:UI
Projects
None yet
Milestone
4.19.2
Development

Successfully merging this pull request may close these issues.

[UI] Metris calculations mismatch - Allocated vs Used
4 participants
@nvazquez @DaanHoogland @blueorangutan @Pearl1594