Skip to content

feature and bug templates #10186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

feature and bug templates #10186

merged 3 commits into from
Jan 17, 2025

Conversation

DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Jan 14, 2025

Description

This PR tries to implement more modern issue templates in github as it seems the old ones are out of date.

It will look like this to users:
image

when choosing bug:
image

when choosing new feature:
image

note that after submitting the issues the descriptions are editable markdown as usual. We might wat to refine these templates a bit, or do that later.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)
  • other
  • [ ]

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.33%. Comparing base (35fe19f) to head (e0af137).
Report is 408 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main   #10186       +/-   ##
=============================================
+ Coverage     15.13%   17.33%    +2.20%     
- Complexity    11272    15836     +4564     
=============================================
  Files          5408     5652      +244     
  Lines        473958   619153   +145195     
  Branches      57811    98997    +41186     
=============================================
+ Hits          71721   107358    +35637     
- Misses       394219   501336   +107117     
- Partials       8018    10459     +2441     
Flag Coverage Δ
uitests 4.63% <ø> (+0.33%) ⬆️
unittests 18.13% <ø> (+2.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Member

@DaanHoogland
do you have a screenshot ?

@DaanHoogland
Copy link
Contributor Author

@DaanHoogland do you have a screenshot ?

yes, thanks for reminding I need to update...

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaanHoogland this looks good. Just a minor improvement request, can you make all the displayed texts capitalized on the first letter of the sentence?

Copy link

@DaanHoogland
Copy link
Contributor Author

@weizhouapache , are you ok with this? I guess we can always update.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland DaanHoogland merged commit 0ed6895 into main Jan 17, 2025
49 of 50 checks passed
@DaanHoogland DaanHoogland deleted the issue_template branch January 17, 2025 10:41
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants