Skip to content

consider a valid ipv4 address as a validish ipv4 /32 cidr #10174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -402,11 +402,17 @@
}
String[] cidrs = _allowedInternalSites.split(",");
for (String cidr : cidrs) {
if (NetUtils.isValidIp4Cidr(cidr) || NetUtils.isValidIp4(cidr) || !cidr.startsWith("0.0.0.0")) {
if (NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) {
if (NetUtils.isValidIp4Cidr(cidr)) {
if (! NetUtils.getCleanIp4Cidr(cidr).equals(cidr)) {
s_logger.warn(String.format("Invalid CIDR %s in %s", cidr, SecStorageAllowedInternalDownloadSites.key()));
}
allowedCidrs.add(cidr);
allowedCidrs.add(NetUtils.getCleanIp4Cidr(cidr));

Check warning on line 409 in services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java

View check run for this annotation

Codecov / codecov/patch

services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java#L409

Added line #L409 was not covered by tests
} else if (NetUtils.isValidIp4(cidr)) {
String newCidr = cidr + "/32";
s_logger.warn(String.format("Ip address is not a valid CIDR; %s using %s/32", cidr, newCidr));
allowedCidrs.add(newCidr);

Check warning on line 413 in services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java

View check run for this annotation

Codecov / codecov/patch

services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java#L411-L413

Added lines #L411 - L413 were not covered by tests
} else if (!cidr.startsWith("0.0.0.0")) {
allowedCidrs.add(NetUtils.getCleanIp4Cidr(cidr));

Check warning on line 415 in services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java

View check run for this annotation

Codecov / codecov/patch

services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java#L415

Added line #L415 was not covered by tests
}
}
return allowedCidrs;
Expand Down
2 changes: 1 addition & 1 deletion utils/src/main/java/com/cloud/utils/net/NetUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ public static boolean isValidIp4Cidr(final String cidr) {

final String[] cidrPair = cidr.split("\\/");
if (cidrPair.length != 2) {
return false;
return isValidIp4(cidr); // we consider an ip4v address as a valid /32 cidr
}
final String cidrAddress = cidrPair[0];
final String cidrSize = cidrPair[1];
Expand Down
Loading