-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add response object required by go SDK for parsing response #10152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.19
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10152 +/- ##
=========================================
Coverage 15.17% 15.17%
+ Complexity 11363 11360 -3
=========================================
Files 5416 5416
Lines 475911 475911
Branches 58096 58096
=========================================
+ Hits 72241 72242 +1
+ Misses 395584 395580 -4
- Partials 8086 8089 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but a lot of new failures. Any idea @Pearl1594 ?
I may have not pulled the latest 4.19 branch - let's see if this helps |
Actually, seems like this is the issue:
Not sure why is this being caused - needs investigation |
|
6931d1b
to
31d5025
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the VM metrics response to include the newly added StatsResponse
object for SDK parsing.
- Added
responseObject = StatsResponse.class
to the@Param
annotation on thestats
field. - Ensures the Go SDK can generate and parse the
StatsResponse
data structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
31d5025
to
ab44533
Compare
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13896 |
|
Description
This PR adds the StatsResponse object which is required by the go SDK - to resolve the following issue: apache/cloudstack-go#97
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?