Skip to content

Add response object required by go SDK for parsing response #10152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR adds the StatsResponse object which is required by the go SDK - to resolve the following issue: apache/cloudstack-go#97

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (cbd2b5a) to head (ab44533).

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10152   +/-   ##
=========================================
  Coverage     15.17%   15.17%           
+ Complexity    11363    11360    -3     
=========================================
  Files          5416     5416           
  Lines        475911   475911           
  Branches      58096    58096           
=========================================
+ Hits          72241    72242    +1     
+ Misses       395584   395580    -4     
- Partials       8086     8089    +3     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but a lot of new failures. Any idea @Pearl1594 ?

@Pearl1594
Copy link
Contributor Author

I may have not pulled the latest 4.19 branch - let's see if this helps

@Pearl1594
Copy link
Contributor Author

Actually, seems like this is the issue:

 /home/runner/.local/lib/python3.10/site-packages/nose/plugins/manager.py:394: RuntimeWarning: Unable to load plugin marvinPlugin = marvin.marvinPlugin:MarvinPlugin: unterminated string literal (detected at line 95) (listVirtualMachinesUsageHistory.py, line 95)
  warn("Unable to load plugin %s: %s" % (ep, e),

Not sure why is this being caused - needs investigation

Copy link

sonarqubecloud bot commented Jan 2, 2025

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the VM metrics response to include the newly added StatsResponse object for SDK parsing.

  • Added responseObject = StatsResponse.class to the @Param annotation on the stats field.
  • Ensures the Go SDK can generate and parse the StatsResponse data structure.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland force-pushed the go-sdk-response-obj branch from 31d5025 to ab44533 Compare June 24, 2025 11:25
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@apache apache deleted a comment from blueorangutan Jun 24, 2025
@apache apache deleted a comment from blueorangutan Jun 24, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13896

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants