Skip to content

pre-commit fix mixed line endings in XML files #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

jbampton
Copy link
Member

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (b48de4e) to head (f37c930).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #10148   +/-   ##
=========================================
  Coverage     16.06%   16.06%           
  Complexity    12871    12871           
=========================================
  Files          5642     5642           
  Lines        493973   493973           
  Branches      59895    59895           
=========================================
+ Hits          79348    79350    +2     
+ Misses       405839   405838    -1     
+ Partials       8786     8785    -1     
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11938

@vishesh92
Copy link
Member

@blueorangutan test

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm. once the tests passes we can merge this PR.

@blueorangutan
Copy link

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-12014)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54732 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10148-t12014-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_nonsecured_to_secured_vm_migration Error 355.39 test_vm_life_cycle.py

@DaanHoogland
Copy link
Contributor

@vishesh92 the error seems unrelated. agree?

@vishesh92
Copy link
Member

@vishesh92 the error seems unrelated. agree?

I agree

@DaanHoogland DaanHoogland merged commit 5bae118 into apache:main Jan 3, 2025
25 checks passed
@jbampton jbampton deleted the fix-mixed-line-endings-in-xml branch January 3, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants