-
Notifications
You must be signed in to change notification settings - Fork 1.2k
pre-commit fix mixed line endings in XML files #10148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit fix mixed line endings in XML files #10148
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10148 +/- ##
=========================================
Coverage 16.06% 16.06%
Complexity 12871 12871
=========================================
Files 5642 5642
Lines 493973 493973
Branches 59895 59895
=========================================
+ Hits 79348 79350 +2
+ Misses 405839 405838 -1
+ Partials 8786 8785 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@blueorangutan package |
@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11938 |
@blueorangutan test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm. once the tests passes we can merge this PR.
@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
[SF] Trillian test result (tid-12014)
|
@vishesh92 the error seems unrelated. agree? |
I agree |
https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#mixed-line-ending
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?