CKS data ISO & VM/template arch mis-match for both CKS & SharedFS features

[rohityadavcloud]

problem

In a multi-arch env, creating CKS cluster doesn't map/check the data ISO arch with the arch of the instances; this can lead to issues where the CKS instances are aarch64, but the data ISO is x86_64.

Instead, the VM is allocated based on the systemvmtemplate, which is hard-coded to the last systemvmtemplate in the DB. It doesn't honour system.vm.preferred.architecture setting, and affects at least the CKS and sharedFS features.

versions

ACS 4.20.1.0 RC3

The steps to reproduce the bug

1. Create CKS cluster in a multi-arch env
2. Data ISO is x86 but instance arch is arm64
3. CKS cluster will fail to be created

What to do about it?

This can be fixed by either the data isos been multi-arch, or the deployment planner to map the right data ISO with the right instance arch.

[rohityadavcloud]

The CKS implementation in 4.20 branch doesn't honour the system.vm.preferred.architecture, instead it uses the last active systemvmtemplate that's a system template for the zone. In a multi-arch env, this means the workaround is to change the order somehow, delete the systemvmtemplate that you don't want or simply change the type of the unwanted systemvmtemplate (arm64 in my case) from 'SYSTEM' to 'USER'.

Example workaround:

Ideally this code here:
https://github.com/apache/cloudstack/blob/4.20/engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java#L577

Or, specifically https://github.com/apache/cloudstack/blob/4.20/engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java#L581 should honour the global setting to filter also by preferred arch (if possible).

[nvazquez]

Thanks @rohityadavcloud I've created a PR to address the issue #10946 - can you check if this solves the issue?